Bug 79275 - [chromium] Fix CCOcclusionTracker unit test assertion
Summary: [chromium] Fix CCOcclusionTracker unit test assertion
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dana Jansens
: 79381 (view as bug list)
Depends on:
Blocks: 75864 79302
  Show dependency treegraph
Reported: 2012-02-22 13:40 PST by Dana Jansens
Modified: 2012-02-23 11:28 PST (History)
4 users (show)

See Also:

Patch (2.35 KB, patch)
2012-02-22 13:41 PST, Dana Jansens
no flags Details | Formatted Diff | Diff
Patch (24.66 KB, patch)
2012-02-22 13:58 PST, Dana Jansens
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dana Jansens 2012-02-22 13:40:36 PST
[chromium] Fix CCOcclusionTracker unit test assertion
Comment 1 Dana Jansens 2012-02-22 13:41:12 PST
The iterators change doesn't seem to be related to this assert. I get it with and without the iterators.
Comment 2 Dana Jansens 2012-02-22 13:41:26 PST
Created attachment 128280 [details]

Was checking the surface which we already left. This is a no-no.
Comment 3 Dana Jansens 2012-02-22 13:58:19 PST
Created attachment 128284 [details]

Similar problem in CCOcclusionTrackerTest.surfaceOcclusionInScreenSpace.

And using EXPECT_TRUE/EXPECT_FALSE for bools.
Comment 4 WebKit Review Bot 2012-02-22 17:41:55 PST
Comment on attachment 128284 [details]

Clearing flags on attachment: 128284

Committed r108587: <http://trac.webkit.org/changeset/108587>
Comment 5 WebKit Review Bot 2012-02-22 17:42:00 PST
All reviewed patches have been landed.  Closing bug.
Comment 6 Tony Chang 2012-02-23 11:28:28 PST
*** Bug 79381 has been marked as a duplicate of this bug. ***