Bug 79260 - REGRESSION (r107516): fast/css/font-face-default-font.html is failing
Summary: REGRESSION (r107516): fast/css/font-face-default-font.html is failing
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P1 Normal
Assignee: Kenichi Ishibashi
Keywords: LayoutTestFailure, Regression
Depends on:
Reported: 2012-02-22 11:05 PST by mitz
Modified: 2012-02-22 22:12 PST (History)
2 users (show)

See Also:

Patch (1.49 KB, patch)
2012-02-22 19:46 PST, Kenichi Ishibashi
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description mitz 2012-02-22 11:05:44 PST
<http://trac.webkit.org/r107516> caused fast/css/font-face-default.font.html to fail. Specifically, the italicized text changed from Arial to Times.
Comment 1 Kenichi Ishibashi 2012-02-22 19:34:34 PST
According to the latest draft spec:
- the default value of font-style descriptor is normal (http://dev.w3.org/csswg/css3-fonts/#font-prop-desc)
- a font which has desirable style (italic in this case) is prioritized others if the font-family is matched (http://dev.w3.org/csswg/css3-fonts/#font-style-matching)

fast/css/font-face-default-font.html defines @font-face without font-style:

@font-face {
    font-family: Times;
    src: local("Arial");

And Mac (and maybe other platforms) has regular and italic Times font. These facts caused the test failure.

I think the current behavior follows the draft spec. Just adding following @font-face will solve the failure.

@font-face {
    font-family: Times;
    font-style: italic;
    src: local("Arial");
Comment 2 mitz 2012-02-22 19:39:16 PST
Makes sense.
Comment 3 Kenichi Ishibashi 2012-02-22 19:46:37 PST
Created attachment 128373 [details]
Comment 4 mitz 2012-02-22 19:48:54 PST
Comment on attachment 128373 [details]

Not really necessary for the test, but easier than updating all the results.
Comment 5 Kenichi Ishibashi 2012-02-22 19:50:24 PST
Comment on attachment 128373 [details]

Thank you!
Comment 6 WebKit Review Bot 2012-02-22 22:12:47 PST
Comment on attachment 128373 [details]

Clearing flags on attachment: 128373

Committed r108609: <http://trac.webkit.org/changeset/108609>
Comment 7 WebKit Review Bot 2012-02-22 22:12:51 PST
All reviewed patches have been landed.  Closing bug.