Bug 79259 - Move FILE_SYSTEM code out of DOMWindow and into the fileapi folder
Summary: Move FILE_SYSTEM code out of DOMWindow and into the fileapi folder
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks: 79327 78440
  Show dependency treegraph
 
Reported: 2012-02-22 10:50 PST by Adam Barth
Modified: 2012-02-23 20:57 PST (History)
4 users (show)

See Also:


Attachments
Patch (20.02 KB, patch)
2012-02-22 10:52 PST, Adam Barth
eric: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2012-02-22 10:50:45 PST
Move FILE_SYSTEM code out of DOMWindow and into the fileapi folder
Comment 1 Adam Barth 2012-02-22 10:52:28 PST
Created attachment 128247 [details]
Patch
Comment 2 Eric Seidel (no email) 2012-02-22 12:00:59 PST
Comment on attachment 128247 [details]
Patch

LGTM.
Comment 3 Eric U. 2012-02-22 12:05:58 PST
Comment on attachment 128247 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=128247&action=review

Nice!  We should do WorkerContext too.

> Source/WebCore/fileapi/DOMWindowFileSystem.idl:23
> +        Conditional=WEB_AUDIO,

WEB_AUDIO?
Comment 4 Adam Barth 2012-02-22 12:13:25 PST
> WEB_AUDIO?

Darn copy/paste!
Comment 5 Adam Barth 2012-02-22 12:14:39 PST
> Nice!  We should do WorkerContext too.

Yep.  Here's the spreadsheet with all the planned changes, if you're curious:

https://docs.google.com/spreadsheet/ccc?key=0AppchfQ5mBrEdFlodHlLb0prdEd1ZEZyUHdCbEpoc2c&userstoinvite=abarth@google.com#gid=0
Comment 6 Adam Barth 2012-02-22 15:07:01 PST
Committed r108556: <http://trac.webkit.org/changeset/108556>