WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
79259
Move FILE_SYSTEM code out of DOMWindow and into the fileapi folder
https://bugs.webkit.org/show_bug.cgi?id=79259
Summary
Move FILE_SYSTEM code out of DOMWindow and into the fileapi folder
Adam Barth
Reported
2012-02-22 10:50:45 PST
Move FILE_SYSTEM code out of DOMWindow and into the fileapi folder
Attachments
Patch
(20.02 KB, patch)
2012-02-22 10:52 PST
,
Adam Barth
eric
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Adam Barth
Comment 1
2012-02-22 10:52:28 PST
Created
attachment 128247
[details]
Patch
Eric Seidel (no email)
Comment 2
2012-02-22 12:00:59 PST
Comment on
attachment 128247
[details]
Patch LGTM.
Eric U.
Comment 3
2012-02-22 12:05:58 PST
Comment on
attachment 128247
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=128247&action=review
Nice! We should do WorkerContext too.
> Source/WebCore/fileapi/DOMWindowFileSystem.idl:23 > + Conditional=WEB_AUDIO,
WEB_AUDIO?
Adam Barth
Comment 4
2012-02-22 12:13:25 PST
> WEB_AUDIO?
Darn copy/paste!
Adam Barth
Comment 5
2012-02-22 12:14:39 PST
> Nice! We should do WorkerContext too.
Yep. Here's the spreadsheet with all the planned changes, if you're curious:
https://docs.google.com/spreadsheet/ccc?key=0AppchfQ5mBrEdFlodHlLb0prdEd1ZEZyUHdCbEpoc2c&userstoinvite=abarth@google.com#gid=0
Adam Barth
Comment 6
2012-02-22 15:07:01 PST
Committed
r108556
: <
http://trac.webkit.org/changeset/108556
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug