Bug 79258 – webkitpy: changelog_unittest test_fuzzy_reviewer_match is slow

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Dirk Pranke]

webkitpy: changelog_unittest test_fuzzy_reviewer_match is slow

[Dirk Pranke]

Created attachment 128246 [details]
Patch

[Dirk Pranke]

Note that this patch doesn't actually work at all :) ...

[Dirk Pranke]

Created attachment 128806 [details]
Patch

[Dirk Pranke]

same deal as bug 79179 ... these fuzzy matching tests are slow so I'm splitting them up so that they can be sharded better.

[Ryosuke Niwa]

Comment on attachment 128806 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=128806&action=review

r=me provided the trailing whitespaces are restored.

> Tools/Scripts/webkitpy/common/checkout/changelog_unittest.py:254
> -100000 [e-mail] 
> +100000 [e-mail]

Please revert these trailing whitespace changes. The actual result contains those whitespaces and we need tests to make sure we can parse them.

[Dirk Pranke]

(In reply to comment #5)
> (From update of attachment 128806 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=128806&action=review
> 
> r=me provided the trailing whitespaces are restored.
> 
> > Tools/Scripts/webkitpy/common/checkout/changelog_unittest.py:254
> > -100000 [e-mail] 
> > +100000 [e-mail]
> 
> Please revert these trailing whitespace changes. The actual result contains those whitespaces and we need tests to make sure we can parse them.

Hm. So you're okay with fixing the regexp? If so, then how about I change the test so that the string is a bunch of concatenated lines with quotes, like:

changelog= ("foo "
                    "bar ")

so that we don't actually have trailing whitespace in the file (while keeping it in the string)? Relying on trailing whitespace in the file for test correctness is horrendous, given that the trailing whitespace may or may not even be visible in an editor :).

[Dirk Pranke]

Created attachment 128828 [details]
patch for landing

[Dirk Pranke]

Committed r108868: <http://trac.webkit.org/changeset/108868>

[Dirk Pranke]

Comment on attachment 128828 [details]
patch for landing

(assuming that that was ok; if it wasn't, let me know and I'll fix it or roll it out).