Bug 79256 - [BlackBerry] Fat fingers - Add a clearer way to distinguish the node we want (shadow or non-shadow)
Summary: [BlackBerry] Fat fingers - Add a clearer way to distinguish the node we want ...
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antonio Gomes
Depends on: 74380
  Show dependency treegraph
Reported: 2012-02-22 10:30 PST by Antonio Gomes
Modified: 2012-02-23 20:28 PST (History)
0 users

See Also:

(landed r108721, r=rbuis) patch v1 (10.61 KB, patch)
2012-02-22 11:14 PST, Antonio Gomes
rwlbuis: review+
tonikitoo: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antonio Gomes 2012-02-22 10:30:07 PST
FatFingers works with both shadow and non-shadow content for accuracy.

There are cases that we are dealing with the FatFingersResult class, but want to restrict operate non-shadow DOM content (for example when checking if it has JS listeners attached to it, doing some text selection stuff, or checking context menu info off of the target node).For other cases, we do not actually care. 

Patch provides cleaner way to get the target we intend to, depending on the situation.
Comment 1 Antonio Gomes 2012-02-22 11:14:55 PST
Created attachment 128251 [details]
(landed r108721, r=rbuis) patch v1
Comment 2 Rob Buis 2012-02-22 11:43:33 PST
Comment on attachment 128251 [details]
(landed r108721, r=rbuis) patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=128251&action=review

Looks good with some stuff to fix before landing.

> Source/WebKit/blackberry/WebKitSupport/FatFingers.h:51
> +enum ContentType { ShadowContentAllowed, ShadowContentNotAllowed };

Better move it into FatFingersResult class before landing.

> Source/WebKit/blackberry/WebKitSupport/FatFingers.h:96
> +    }

Not sure if this makes sense inlined, might need measurements, not required for landing this though.