Bug 79253 – WebKit2: implement platform strategy to access Pasteboard in the UI process.

• Status: RESOLVED
• Resolution: FIXED
• Component: HTML Editing

[Enrica Casucci]

This bugs tracks the work required to implement the message exchanging with the UIProcess to move the access to NSPasteboard out of the WebProcess.

[Enrica Casucci]

Created attachment 128238 [details]
Patch

[Alexey Proskuryakov]

Comment on attachment 128238 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=128238&action=review

Can sandbox profile be updated now, blocking pasteboard access?

> Source/WebKit2/UIProcess/WebContext.cpp:625
> +#if PLATFORM(MAC)
> +void WebContext::getPasteboardTypes(const String& pasteboardName, Vector<String>& pasteboardTypes)

Can this code go to WebContextMac.mm instead?

> Source/WebKit2/UIProcess/WebContext.cpp:642
> +    RefPtr<WebCore::SharedBuffer> buffer = PlatformPasteboard(pasteboardName).bufferForType(pasteboardType);

Is this WebCore:: prefix needed?

[WebKit Commit Bot]

Attachment 128238 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebKit2/UIProcess/WebContext.h:232:  The parameter name "handle" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit2/UIProcess/WebContext.h:236:  The parameter name "color" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit2/UIProcess/WebContext.h:240:  The parameter name "handle" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 3 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Enrica Casucci]

(In reply to comment #2)
> (From update of attachment 128238 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=128238&action=review
> 
> Can sandbox profile be updated now, blocking pasteboard access?
> 
> > Source/WebKit2/UIProcess/WebContext.cpp:625
> > +#if PLATFORM(MAC)
> > +void WebContext::getPasteboardTypes(const String& pasteboardName, Vector<String>& pasteboardTypes)
> 
> Can this code go to WebContextMac.mm instead?
>
Yes, I'll move it. 
> > Source/WebKit2/UIProcess/WebContext.cpp:642
> > +    RefPtr<WebCore::SharedBuffer> buffer = PlatformPasteboard(pasteboardName).bufferForType(pasteboardType);
> 
> Is this WebCore:: prefix needed?
No, I'll remove it.

[Enrica Casucci]

(In reply to comment #2)
> (From update of attachment 128238 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=128238&action=review
> 
> Can sandbox profile be updated now, blocking pasteboard access?
> 
Not yet, there is still one patch I'm working on to remove the access performed in WebDragClient.cpp.
I need to move to the UI process all the code that deals with the NSPromisedFile stuff.

[Enrica Casucci]

(In reply to comment #3)
> Attachment 128238 [details] did not pass style-queue:
> 
> Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
> Source/WebKit2/UIProcess/WebContext.h:232:  The parameter name "handle" adds no information, so it should be removed.  [readability/parameter_name] [5]
> Source/WebKit2/UIProcess/WebContext.h:236:  The parameter name "color" adds no information, so it should be removed.  [readability/parameter_name] [5]
> Source/WebKit2/UIProcess/WebContext.h:240:  The parameter name "handle" adds no information, so it should be removed.  [readability/parameter_name] [5]
> Total errors found: 3 in 7 files
> 
> 
> If any of these errors are false positives, please file a bug against check-webkit-style.

Will fix style issues before landing.

[Enrica Casucci]

http://trac.webkit.org/changeset/109022

[Andy Estes]

It looks like this broke file uploads to icloud.com. I filed <https://bugs.webkit.org/show_bug.cgi?id=80475>.