Bug 79245 - Web Inspector: in start-at-zero mode of timeline panel, calculate window boundaries based on filtered events
Summary: Web Inspector: in start-at-zero mode of timeline panel, calculate window boun...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Andrey Kosyakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-22 08:46 PST by Andrey Kosyakov
Modified: 2012-05-17 07:45 PDT (History)
10 users (show)

See Also:

Attachments
Patch (2.99 KB, patch)
2012-02-22 08:47 PST, Andrey Kosyakov 		no flags Details | Formatted Diff | Diff
Patch (14.70 KB, patch)
2012-02-24 04:37 PST, Andrey Kosyakov 		pfeldman: review-
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrey Kosyakov 2012-02-22 08:46:44 PST 
Only include records in selection window when calculating event boundaries (i.e. pick scale according to visible events).
Comment 1 Andrey Kosyakov 2012-02-22 08:47:41 PST 
Created attachment 128223 [details]
Patch
Comment 2 Pavel Feldman 2012-02-22 08:50:05 PST 
Comment on attachment 128223 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=128223&action=review

> Source/WebCore/inspector/front-end/TimelinePanel.js:748
> +        if (!this._boundariesAreValid && !this._startAtZero)

This looks like a hack, we should come up with a better filtering strategy.
Comment 3 Andrey Kosyakov 2012-02-24 04:37:44 PST 
Created attachment 128708 [details]
Patch
Comment 4 Pavel Feldman 2012-02-24 04:53:29 PST 
Comment on attachment 128708 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=128708&action=review

> Source/WebCore/inspector/front-end/TimelineOverviewPane.js:161
> +        this._presentationModel.setWindowTimes(leftTime, rightTime);

setWindowTimes -> setVisibleRecords (range)
Comment 5 Andrey Kosyakov 2012-05-17 07:45:59 PDT 
This has been fixed by another change and works well now.