Bug 79226 - [GTK] Implement print preview
Summary: [GTK] Implement print preview
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Tomas Popela
URL:
Keywords: Gtk
Depends on:
Blocks: 75544
  Show dependency treegraph
 
Reported: 2012-02-22 05:07 PST by Carlos Garcia Campos
Modified: 2022-09-05 01:14 PDT (History)
7 users (show)

See Also:


Attachments
Patch (14.26 KB, patch)
2016-12-01 07:44 PST, Tomas Popela
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2012-02-22 05:07:58 PST
It's currently unsupported.
Comment 1 Martin Robinson 2015-05-07 18:24:58 PDT
What all do we need to do for this?
Comment 2 Carlos Garcia Campos 2015-05-07 22:38:11 PDT
We probably need a way to send the PDF from the web process to the UI process.
Comment 3 Milan Crha 2016-02-16 06:27:54 PST
I do not know the rationale behind this, but with respect of the Gtk's print dialog, you get all of that for free, both Print Preview and Export to PDF (yes, that's also sometimes useful), if you just reuse what the gtk offer. All you need to do is to implement three signals on the GtkPrintOperation, as shown in the simple example [1], which can be run in gtk3-demo, Printing->Printing demo. Reuse of the code is beneficial, I believe, especially when you get things for free.

[1] https://git.gnome.org/browse/gtk+/tree/demos/gtk-demo/printing.c#n158
Comment 4 Carlos Garcia Campos 2016-02-16 08:34:45 PST
Unfortunately this is not that easy in WebKit2 model. We run the dialog in the ui process, but the print operation in the web process. So we use the unix print dialog manually, and a custom print operation in the web process. So, the UI process simply collects the options form the print dialog, and the web process does the actual printing to a file that is sent to the printer with GtkPrintJob
Comment 5 Tomas Popela 2016-12-01 07:44:55 PST
Created attachment 295851 [details]
Patch
Comment 6 Tomas Popela 2016-12-01 07:49:30 PST
I added a wip implementation (but it's working) just to have some opinion from other devs if this is the right way to implement this (we talked about this with Carlos during the hackfest). For the description please see the change logs.
Comment 7 Milan Crha 2017-02-27 04:57:26 PST
Just for a record, recent downstream bug report against Evolution:
https://bugzilla.gnome.org/show_bug.cgi?id=779254
Comment 8 Michael Gratton 2018-04-26 23:27:54 PDT
FWIW, Flatpak's xdg-desktop-portal-gtk just did something similar using evince-previewer for its print preview implementation, which has the same challenges as the WK2 model:

https://github.com/flatpak/xdg-desktop-portal-gtk/commit/8710c71022e60543881bbe7dbefb76285ab03a34
Comment 9 Carlos Garcia Campos 2022-09-05 01:14:44 PDT
Now that we have PDF support we can probably implement print preview using a web view.