Bug 79225 - Drop clipToImageBuffer from RenderBoxModelObject
Summary: Drop clipToImageBuffer from RenderBoxModelObject
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Enhancement
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-22 04:51 PST by Zoltan Herczeg
Modified: 2012-02-22 06:19 PST (History)
3 users (show)

See Also:

Attachments
patch (4.45 KB, patch)
2012-02-22 05:04 PST, Zoltan Herczeg 		zimmermann: review+
Details | Formatted Diff | Diff
perf test (background image is not attached) (1.12 KB, text/plain)
2012-02-22 05:06 PST, Zoltan Herczeg 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zoltan Herczeg 2012-02-22 04:51:27 PST 
Continue the quest to drop clipToImageBuffer from WebKit.

The bgLayer->clip() == TextFillBox is a non-standard rarely used feature. The replacement code has the same speed on Mac.
Comment 1 Zoltan Herczeg 2012-02-22 05:04:52 PST 
Created attachment 128179 [details]
patch
Comment 2 Zoltan Herczeg 2012-02-22 05:06:14 PST 
Created attachment 128180 [details]
perf test (background image is not attached)
Comment 3 Nikolas Zimmermann 2012-02-22 05:27:32 PST 
Comment on attachment 128179 [details]
patch

Looks great, r=me.  As cr-linux is green as well, I assume this doesn't change pixel tests at all.
Comment 4 Zoltan Herczeg 2012-02-22 05:29:59 PST 
Yeah. Now it is green :)
Comment 5 Zoltan Herczeg 2012-02-22 06:19:03 PST 
http://trac.webkit.org/changeset/108492