Bug 79216 – [BlackBerry] Upstream helper classes for skia

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Robin Cao]

Add helper classes in platform/graphics/blackberry/skia
    ImageBufferData.h
    PlatformSupport.cpp
    PlatformSupport.h

[Robin Cao]

Created attachment 128166 [details]
patch

[Antonio Gomes]

Comment on attachment 128166 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=128166&action=review

> Source/WebCore/platform/graphics/blackberry/skia/PlatformSupport.cpp:100
> +    FcBool b;
> +    int i;

b and i does not make it easy to understand their use.

> Source/WebCore/platform/graphics/blackberry/skia/PlatformSupport.cpp:114
> +#if 0
> +    // FIXME: Fontconfig tells us to use aggressive hinting, but FreeType breaks with our Adobe fonts
> +    if (FcPatternGetInteger(match, FC_HINT_STYLE, 0, &i) == FcResultMatch)
> +         out->hintStyle = i;
> +#endif

up to drop this comment?

> Source/WebCore/platform/graphics/blackberry/skia/PlatformSupport.cpp:147
> +        if (U16_IS_SURROGATE(characters[i])
> +         && U16_IS_SURROGATE_LEAD(characters[i])
> +         && i != numCharacters - 1
> +         && U16_IS_TRAIL(characters[i + 1])) {
> +              FcCharSetAddChar(cset, U16_GET_SUPPLEMENTARY(characters[i], characters[i+1]));
> +          i++;
> +        } else
> +              FcCharSetAddChar(cset, characters[i]);

wrong code style (indentation)

> Source/WebCore/platform/graphics/blackberry/skia/PlatformSupport.cpp:198
> +        }
> +        int weight;

add blank line between these two

> Source/WebCore/platform/graphics/blackberry/skia/PlatformSupport.cpp:203
> +            family->isBold = false;
> +        int slant;

ditto

> Source/WebCore/platform/graphics/blackberry/skia/PlatformSupport.cpp:208
> +            family->isItalic = false;
> +        FcFontSetDestroy(fontSet);

ditto

> Source/WebCore/platform/graphics/blackberry/skia/PlatformSupport.h:43
> +// This is a minimal version of the Chromium PlatformSupport/WebFontInfo classes used for font support
> +
> +class PlatformSupport {

drop blank line, add "." at the end

[Robin Cao]

Thanks for the review. Will address your comments before landing.

[Robin Cao]

Created attachment 128660 [details]
Updated patch for landing

[Leo Yang]

Comment on attachment 128660 [details]
Updated patch for landing

Sending to cq...

[WebKit Review Bot]

Comment on attachment 128660 [details]
Updated patch for landing

Clearing flags on attachment: 128660

Committed r108775: <http://trac.webkit.org/changeset/108775>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.