Bug 79201 - Node::attach() should be after attaching children in Element::attach
Summary: Node::attach() should be after attaching children in Element::attach
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Shinya Kawanaka
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-21 23:03 PST by Shinya Kawanaka
Modified: 2012-02-22 02:12 PST (History)
1 user (show)

See Also:

Attachments
Patch (1.67 KB, patch)
2012-02-21 23:07 PST, Shinya Kawanaka 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Shinya Kawanaka 2012-02-21 23:03:25 PST 
In Element::attach(), Node::attach() is called before attaching children if a shadow root exists.
This may cause O(N^2) problem in NodeRenderingContext.
Comment 1 Shinya Kawanaka 2012-02-21 23:07:46 PST 
Created attachment 128138 [details]
Patch
Comment 2 WebKit Review Bot 2012-02-22 02:12:17 PST 
Comment on attachment 128138 [details]
Patch

Clearing flags on attachment: 128138

Committed r108470: <http://trac.webkit.org/changeset/108470>
Comment 3 WebKit Review Bot 2012-02-22 02:12:21 PST 
All reviewed patches have been landed.  Closing bug.