Bug 79183 – [chromium] Avoid culling work for fully-non-opaque tiles, and add tracing for draw culling

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Dana Jansens]

[chromium] Avoid culling work for fully-non-opaque tiles, and add tracing for draw culling

[Dana Jansens]

Created attachment 128109 [details]
Patch

[Vangelis Kokkevis]

Comment on attachment 128109 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=128109&action=review

(Unofficially) LGTM

> Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:244
> +    TRACE_EVENT("CCLayerTreeHostImpl::optimizeRenderPasses()", this, 0);

Maybe a good opportunity to also report the # of passes here too?

[James Robinson]

Comment on attachment 128109 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=128109&action=review

>> Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:244
>> +    TRACE_EVENT("CCLayerTreeHostImpl::optimizeRenderPasses()", this, 0);
> 
> Maybe a good opportunity to also report the # of passes here too?

We haven't been putting the '()' in traces for functions before. There's no really strong reason for or against this convention, but it's what we've been using so I'd like to stay consistent.

I believe you can pass parameters efficiently now by using the TRACE_EVENT1() macro instead of TRACE_EVENT.  See the comments in TraceEvent.h for details

[Vangelis Kokkevis]

Comment on attachment 128109 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=128109&action=review

> Source/WebCore/platform/graphics/chromium/cc/CCQuadCuller.cpp:104
> +        if (keepQuad && drawQuad->isLayerAxisAlignedIntRect() && !drawQuad->opaqueRect().isEmpty()) {

One more quick comment:  I think this loop could be simplified if you add an early out ("continue") after line 96:

if (!keepQuad)
   continue;

That way you won't need to keep checking that keepQuad == true

[Dana Jansens]

Created attachment 128621 [details]
Patch

Looking for review again to make sure I got this TRACE_EVENT foo correct. I had to cast the passes.size() to make it compile, as size_t confused it and it wasn't sure if "unsigned long" should be an "unsigned long long" or an "unsigned int", etc.

@vangelis good call with the continue!

[James Robinson]

Comment on attachment 128621 [details]
Patch

Thumbsup!

[WebKit Review Bot]

The commit-queue encountered the following flaky tests while processing attachment 128621 [details]:

perf/mouse-event.html bug 78736 (author: [e-mail])
The commit-queue is continuing to process your patch.

[WebKit Review Bot]

Comment on attachment 128621 [details]
Patch

Clearing flags on attachment: 128621

Committed r108764: <http://trac.webkit.org/changeset/108764>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Dana Jansens]

*** Bug 76578 has been marked as a duplicate of this bug. ***