Bug 79174 - Early-out in Region::unite() for adding an empty region.
Summary: Early-out in Region::unite() for adding an empty region.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dana Jansens
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-21 18:05 PST by Dana Jansens
Modified: 2012-02-21 18:58 PST (History)
6 users (show)

See Also:


Attachments
Patch (1.25 KB, patch)
2012-02-21 18:06 PST, Dana Jansens
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dana Jansens 2012-02-21 18:05:26 PST
Early-out in Region::unite() for adding an empty region.
Comment 1 Dana Jansens 2012-02-21 18:06:27 PST
Created attachment 128099 [details]
Patch

We've noticed that unite() with an empty region ends up making a copy of the entire current Region, and may also add an empty rect in the return from rects(). This early out saves a lot of work for this case, and fixes Region uniqueness for the given area it covers.
Comment 2 WebKit Review Bot 2012-02-21 18:58:39 PST
Comment on attachment 128099 [details]
Patch

Clearing flags on attachment: 128099

Committed r108433: <http://trac.webkit.org/changeset/108433>
Comment 3 WebKit Review Bot 2012-02-21 18:58:43 PST
All reviewed patches have been landed.  Closing bug.