Bug 79165 - Enable ScrollingCoordinator in chromium whenever compositing is enabled
Summary: Enable ScrollingCoordinator in chromium whenever compositing is enabled
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: James Robinson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-21 16:34 PST by James Robinson
Modified: 2012-02-21 17:04 PST (History)
7 users (show)

See Also:


Attachments
Patch (7.76 KB, patch)
2012-02-21 16:38 PST, James Robinson
abarth: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description James Robinson 2012-02-21 16:34:02 PST
Enable ScrollingCoordinator in chromium whenever compositing is enabled
Comment 1 James Robinson 2012-02-21 16:38:01 PST
Created attachment 128081 [details]
Patch
Comment 2 James Robinson 2012-02-21 16:41:49 PST
This is mostly a Chromium-specific change, but it also touches a few pieces of cross-platform code that was making assumptions based off of ScrollingCoordinator that aren't true in Chromium.
Comment 3 Adam Barth 2012-02-21 16:44:22 PST
Comment on attachment 128081 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=128081&action=review

> Source/WebCore/rendering/RenderLayerBacking.cpp:104
> +#if PLATFORM(MAC)

Is this right?  There's no more-specific ifdef?
Comment 4 James Robinson 2012-02-21 16:59:54 PST
(In reply to comment #3)
> (From update of attachment 128081 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=128081&action=review
> 
> > Source/WebCore/rendering/RenderLayerBacking.cpp:104
> > +#if PLATFORM(MAC)
> 
> Is this right?  There's no more-specific ifdef?

I'm not aware of one.  tiledLayerCache is a CoreAnimation-specific thingy and this appears to be a mac-specific tweak, given that ScrollingCoordinator is only enabled on Mac and Chromium and Chromium doesn't use CoreAnimation.  Given the FIXME I imagine that Anders has some plan to clean this up, so hopefully he can improve this is there's a clear way to do that.
Comment 5 James Robinson 2012-02-21 17:04:03 PST
Committed r108422: <http://trac.webkit.org/changeset/108422>