webkitpy: speed up hot filesystem_mock functions
Created attachment 128068 [details] Patch
Comment on attachment 128068 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=128068&action=review > Tools/ChangeLog:11 > + slow.This patch speeds them up substantially, shaving 20 seconds > + off of the execution time. Nice! (nit: missing a space between "." and "This")
Comment on attachment 128068 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=128068&action=review >> Tools/ChangeLog:11 >> + off of the execution time. > > Nice! (nit: missing a space between "." and "This") I'm surprised that this saves 20s... Crazy. > Tools/Scripts/webkitpy/common/system/filesystem_mock.py:179 > + return re.sub(re.escape(os.path.sep), self.sep, os.path.join(*comps)) compiling the regexp would help, no?
Committed r108414: <http://trac.webkit.org/changeset/108414>