RESOLVED FIXED 79159
webkitpy: speed up frequently called but slow filesystem_mock functions 
https://bugs.webkit.org/show_bug.cgi?id=79159
Summary webkitpy: speed up frequently called but slow filesystem_mock functions
Dirk Pranke
Reported 2012-02-21 16:00:43 PST
webkitpy: speed up hot filesystem_mock functions
Attachments
Patch (9.19 KB, patch)
2012-02-21 16:04 PST, Dirk Pranke 		abarth: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dirk Pranke
Comment 1 2012-02-21 16:04:24 PST
Created attachment 128068 [details] Patch
Adam Barth
Comment 2 2012-02-21 16:13:48 PST
Comment on attachment 128068 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=128068&action=review > Tools/ChangeLog:11 > + slow.This patch speeds them up substantially, shaving 20 seconds > + off of the execution time. Nice! (nit: missing a space between "." and "This")
Eric Seidel (no email)
Comment 3 2012-02-21 16:17:29 PST
Comment on attachment 128068 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=128068&action=review >> Tools/ChangeLog:11 >> + off of the execution time. > > Nice! (nit: missing a space between "." and "This") I'm surprised that this saves 20s... Crazy. > Tools/Scripts/webkitpy/common/system/filesystem_mock.py:179 > + return re.sub(re.escape(os.path.sep), self.sep, os.path.join(*comps)) compiling the regexp would help, no?
Dirk Pranke
Comment 4 2012-02-21 16:32:12 PST
Committed r108414: <http://trac.webkit.org/changeset/108414>
Note You need to log in before you can comment on or make changes to this bug.