Bug 79157 - [chromium] Painting a layer clears opaque rect in untouched tiles
Summary: [chromium] Painting a layer clears opaque rect in untouched tiles
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dana Jansens
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-21 15:42 PST by Dana Jansens
Modified: 2012-02-21 18:45 PST (History)
5 users (show)

See Also:


Attachments
Patch (7.28 KB, patch)
2012-02-21 16:46 PST, Dana Jansens
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dana Jansens 2012-02-21 15:42:01 PST
[chromium] Painting a layer clears opaque rect in untouched tiles
Comment 1 Dana Jansens 2012-02-21 16:46:12 PST
Created attachment 128084 [details]
Patch
Comment 2 James Robinson 2012-02-21 16:50:54 PST
Is this fixing a correctness bug or a performance improvement? I would expect that throwing away opaqueness could never result in an incorrect rendering, but might cause you to go slower sometimes.
Comment 3 Dana Jansens 2012-02-21 17:58:11 PST
Yes, performance. I noticed it while fixing the G+ bug, as many tiles were being drawn correctly when they should have stayed (incorrectly) opaque from the bug.
Comment 4 James Robinson 2012-02-21 18:08:20 PST
Comment on attachment 128084 [details]
Patch

Gotcha, thanks for the clarification. Looks good.
Comment 5 WebKit Review Bot 2012-02-21 18:45:02 PST
Comment on attachment 128084 [details]
Patch

Clearing flags on attachment: 128084

Committed r108431: <http://trac.webkit.org/changeset/108431>
Comment 6 WebKit Review Bot 2012-02-21 18:45:06 PST
All reviewed patches have been landed.  Closing bug.