RESOLVED FIXED 79153
Web Inspector: CodeGeneratorInspector.py: remove neural-net-style constructions 
https://bugs.webkit.org/show_bug.cgi?id=79153
Summary Web Inspector: CodeGeneratorInspector.py: remove neural-net-style constructions
Peter Rybin
Reported 2012-02-21 15:23:15 PST
Generator still has some resemblance to a neural network, meaning that it has some irregular structures that were "trained" to generate the right output for a certain input. Replace such structures with more regular ones and make sure its uniform for all types.
Attachments
Patch (38.17 KB, patch)
2012-02-21 15:48 PST, Peter Rybin 		no flags
DetailsFormatted DiffDiff
old InspectorBackendDispatcher.h (30.12 KB, text/plain)
2012-02-21 16:16 PST, Peter Rybin 		no flags
Details
old InspectorFrontend.h (19.54 KB, text/plain)
2012-02-21 16:16 PST, Peter Rybin 		no flags
Details
old InspectorFrontend.cpp (42.90 KB, text/plain)
2012-02-21 16:17 PST, Peter Rybin 		no flags
Details
new InspectorBackendDispatcher.h (29.57 KB, text/plain)
2012-02-21 16:18 PST, Peter Rybin 		no flags
Details
new InspctorFrontend.h (19.54 KB, text/plain)
2012-02-21 16:18 PST, Peter Rybin 		no flags
Details
new InspectorFrontend.cpp (42.93 KB, text/plain)
2012-02-21 16:19 PST, Peter Rybin 		no flags
Details
Patch (38.17 KB, patch)
2012-02-22 06:15 PST, Peter Rybin 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Peter Rybin
Comment 1 2012-02-21 15:48:37 PST
Created attachment 128063 [details] Patch
Peter Rybin
Comment 2 2012-02-21 16:16:24 PST
Created attachment 128072 [details] old InspectorBackendDispatcher.h
Peter Rybin
Comment 3 2012-02-21 16:16:58 PST
Created attachment 128073 [details] old InspectorFrontend.h
Peter Rybin
Comment 4 2012-02-21 16:17:18 PST
Created attachment 128074 [details] old InspectorFrontend.cpp
Peter Rybin
Comment 5 2012-02-21 16:18:25 PST
Created attachment 128075 [details] new InspectorBackendDispatcher.h
Peter Rybin
Comment 6 2012-02-21 16:18:45 PST
Created attachment 128076 [details] new InspctorFrontend.h
Peter Rybin
Comment 7 2012-02-21 16:19:15 PST
Created attachment 128077 [details] new InspectorFrontend.cpp
Yury Semikhatsky
Comment 8 2012-02-22 03:56:42 PST
Comment on attachment 128063 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=128063&action=review > Source/WebCore/inspector/InspectorDebuggerAgent.cpp:533 > + String* sourceMapURLParam = sourceMapURL.isNull() ? 0 : & sourceMapURL; style nit: remove extra space between & and sourceMapURL
Peter Rybin
Comment 9 2012-02-22 06:15:33 PST
Created attachment 128197 [details] Patch
Yury Semikhatsky
Comment 10 2012-02-22 07:05:03 PST
Comment on attachment 128197 [details] Patch Clearing flags on attachment: 128197 Committed r108496: <http://trac.webkit.org/changeset/108496>
Yury Semikhatsky
Comment 11 2012-02-22 07:05:13 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.