http://dev.w3.org/csswg/css3-grid-align/#grid-row-property http://dev.w3.org/csswg/css3-grid-align/#grid-column-property This is a first step into properly parsing them. We limit the syntax to <integer> | 'auto' to have a manageable size for the change. Note: there has been some proposal about renaming them but for now no one backed this change so we will likely have to rename them down the road.
Created attachment 128050 [details] Early patch to discuss the naming.
Comment on attachment 128050 [details] Early patch to discuss the naming. View in context: https://bugs.webkit.org/attachment.cgi?id=128050&action=review The naming seems fine to me. > Source/WebCore/ChangeLog:12 > + -webkit-{row|column} := <integer> | 'auto' -webkit-grid-{row|column}
Created attachment 128530 [details] Fully working patch.
Comment on attachment 128530 [details] Fully working patch. View in context: https://bugs.webkit.org/attachment.cgi?id=128530&action=review > Source/WebCore/css/CSSComputedStyleDeclaration.cpp:920 > +static PassRefPtr<CSSValue> valueForGridPosition(const Length& position, const RenderStyle* style, CSSValuePool* cssValuePool) Looks like the unused parameter |style| is making the mac EWS sad. I will update the patch to make them happy.
Created attachment 128625 [details] Updated patch: fixed the Mac build.
Created attachment 128786 [details] Rebaselined XCode file.
Comment on attachment 128786 [details] Rebaselined XCode file. View in context: https://bugs.webkit.org/attachment.cgi?id=128786&action=review Please merge the JS file into the html test before committing. > LayoutTests/fast/css-grid-layout/grid-item-column-row-get-set.html:26 > +<script src="resources/grid-item-column-row-get-set.js"></script> I'd rather you inline the JS here. Having multiple files for a test is a pain.
Committed r108855: <http://trac.webkit.org/changeset/108855>