Bug 79148 – nrwt: make the delay between starting workers configurable per-port

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Dirk Pranke]

nrwt: make the delay between starting workers configurable per-port

[Dirk Pranke]

Created attachment 128041 [details]
Patch

[Dirk Pranke]

See bug 79147 for the underlying problem we're working around.

[Eric Seidel (no email)]

Comment on attachment 128041 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=128041&action=review

> Tools/Scripts/webkitpy/layout_tests/port/base.py:177
> +        # FIXME: If we start workers up too quickly, DumpRenderTree appears
> +        # to thrash on something and time out its first few tests. Until
> +        # we can figure out what's going on, sleep a bit in between
> +        # workers. See https://bugs.webkit.org/show_bug.cgi?id=79147 .
> +        return 0.1

On which ports does this occur?  Can we do this only on some ports?

[Dirk Pranke]

(In reply to comment #3)
> (From update of attachment 128041 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=128041&action=review
> 
> > Tools/Scripts/webkitpy/layout_tests/port/base.py:177
> > +        # FIXME: If we start workers up too quickly, DumpRenderTree appears
> > +        # to thrash on something and time out its first few tests. Until
> > +        # we can figure out what's going on, sleep a bit in between
> > +        # workers. See https://bugs.webkit.org/show_bug.cgi?id=79147 .
> > +        return 0.1
> 
> On which ports does this occur?  Can we do this only on some ports?

I'm not sure ... hopefully? My plan was to land this so we can speed up test-webkitpy, and then start hunting, port-by-port. I'm only fairly certainly about the delay on apple mac; it may be that that's the only one, or others also have, or in fact no one does any more.

[Dirk Pranke]

Committed r108413: <http://trac.webkit.org/changeset/108413>