Bug 79127 - Remove obsolete float comparison FIXMEs
Summary: Remove obsolete float comparison FIXMEs
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Emil A Eklund
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-21 10:51 PST by Emil A Eklund
Modified: 2012-02-21 11:33 PST (History)
4 users (show)

See Also:


Attachments
Patch (7.86 KB, patch)
2012-02-21 10:55 PST, Emil A Eklund
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Emil A Eklund 2012-02-21 10:51:28 PST
Back when we where still considering using floating point units for the layout tree we added a bunch of FIXME comments in places where we would have to change comparison to use epsilon. Those comments are now obsolete as we no longer intend to use float point.
Comment 1 Emil A Eklund 2012-02-21 10:55:16 PST
Created attachment 128000 [details]
Patch
Comment 2 Eric Seidel (no email) 2012-02-21 10:58:27 PST
Comment on attachment 128000 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=128000&action=review

OK.

> Source/WebCore/rendering/RenderBlock.cpp:1520
>              repaintRectangle(repaintRect); // We need to do a partial repaint of our content.

Does this need rounding now?
Comment 3 Emil A Eklund 2012-02-21 11:21:13 PST
Comment on attachment 128000 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=128000&action=review

>> Source/WebCore/rendering/RenderBlock.cpp:1520
>>              repaintRectangle(repaintRect); // We need to do a partial repaint of our content.
> 
> Does this need rounding now?

Nope, repaintRectangle takes a LayoutRect.
Comment 4 Emil A Eklund 2012-02-21 11:32:42 PST
Committed r108377: <http://trac.webkit.org/changeset/108377>