Bug 79121 - Move PropertySetCSSStyleDeclaration to a file of its own
Summary: Move PropertySetCSSStyleDeclaration to a file of its own
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-21 09:18 PST by Antti Koivisto
Modified: 2012-02-21 10:39 PST (History)
7 users (show)

See Also:


Attachments
patch (109.02 KB, patch)
2012-02-21 09:22 PST, Antti Koivisto
kling: review+
pnormand: commit-queue-
Details | Formatted Diff | Diff
now with header included (115.09 KB, patch)
2012-02-21 09:32 PST, Antti Koivisto
pnormand: commit-queue-
Details | Formatted Diff | Diff
with gtk build file (115.67 KB, patch)
2012-02-21 09:39 PST, Antti Koivisto
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2012-02-21 09:18:25 PST
From StylePropertySet.cpp
Comment 1 Antti Koivisto 2012-02-21 09:22:01 PST
Created attachment 127984 [details]
patch
Comment 2 Antti Koivisto 2012-02-21 09:23:02 PST
"StylePropertySetCSSStyleDeclaration" would be more consistent but repeating "Style" looks bit silly.
Comment 3 Philippe Normand 2012-02-21 09:28:17 PST
Comment on attachment 127984 [details]
patch

Attachment 127984 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/11559159
Comment 4 Early Warning System Bot 2012-02-21 09:29:28 PST
Comment on attachment 127984 [details]
patch

Attachment 127984 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/11520167
Comment 5 Andreas Kling 2012-02-21 09:30:59 PST
Comment on attachment 127984 [details]
patch

rs=me
Comment 6 Antti Koivisto 2012-02-21 09:32:21 PST
Created attachment 127986 [details]
now with header included
Comment 7 Philippe Normand 2012-02-21 09:36:49 PST
Comment on attachment 127986 [details]
now with header included

Attachment 127986 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/11562149
Comment 8 Antti Koivisto 2012-02-21 09:39:51 PST
Created attachment 127988 [details]
with gtk build file
Comment 9 WebKit Review Bot 2012-02-21 10:26:59 PST
Comment on attachment 127988 [details]
with gtk build file

Attachment 127988 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/11557154
Comment 10 Antti Koivisto 2012-02-21 10:38:54 PST
http://trac.webkit.org/changeset/108370

(with Chromium build file fix)