RESOLVED FIXED 79121
Move PropertySetCSSStyleDeclaration to a file of its own
https://bugs.webkit.org/show_bug.cgi?id=79121
Summary Move PropertySetCSSStyleDeclaration to a file of its own
Antti Koivisto
Reported 2012-02-21 09:18:25 PST
From StylePropertySet.cpp
Attachments
patch (109.02 KB, patch)
2012-02-21 09:22 PST, Antti Koivisto
kling: review+
pnormand: commit-queue-
now with header included (115.09 KB, patch)
2012-02-21 09:32 PST, Antti Koivisto
pnormand: commit-queue-
with gtk build file (115.67 KB, patch)
2012-02-21 09:39 PST, Antti Koivisto
webkit.review.bot: commit-queue-
Antti Koivisto
Comment 1 2012-02-21 09:22:01 PST
Antti Koivisto
Comment 2 2012-02-21 09:23:02 PST
"StylePropertySetCSSStyleDeclaration" would be more consistent but repeating "Style" looks bit silly.
Philippe Normand
Comment 3 2012-02-21 09:28:17 PST
Early Warning System Bot
Comment 4 2012-02-21 09:29:28 PST
Andreas Kling
Comment 5 2012-02-21 09:30:59 PST
Comment on attachment 127984 [details] patch rs=me
Antti Koivisto
Comment 6 2012-02-21 09:32:21 PST
Created attachment 127986 [details] now with header included
Philippe Normand
Comment 7 2012-02-21 09:36:49 PST
Comment on attachment 127986 [details] now with header included Attachment 127986 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/11562149
Antti Koivisto
Comment 8 2012-02-21 09:39:51 PST
Created attachment 127988 [details] with gtk build file
WebKit Review Bot
Comment 9 2012-02-21 10:26:59 PST
Comment on attachment 127988 [details] with gtk build file Attachment 127988 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/11557154
Antti Koivisto
Comment 10 2012-02-21 10:38:54 PST
http://trac.webkit.org/changeset/108370 (with Chromium build file fix)
Note You need to log in before you can comment on or make changes to this bug.