Bug 79116 - Web Inspector: do not filter out requestAnimationFrame from timeline, implement stop on animation events.
Summary: Web Inspector: do not filter out requestAnimationFrame from timeline, impleme...
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
Depends on:
Reported: 2012-02-21 08:41 PST by Pavel Feldman
Modified: 2012-02-22 09:29 PST (History)
11 users (show)

See Also:

Patch (29.22 KB, patch)
2012-02-21 08:43 PST, Pavel Feldman
yurys: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2012-02-21 08:41:25 PST
Patch to follow.
Comment 1 Pavel Feldman 2012-02-21 08:43:19 PST
Created attachment 127979 [details]
Comment 2 Yury Semikhatsky 2012-02-22 04:05:01 PST
Comment on attachment 127979 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=127979&action=review

> Source/WebCore/dom/ScriptedAnimationController.cpp:88
> +    InspectorInstrumentation::didRequestAnimationFrameCallback(m_document, id);

didRequestAnimationFrameCallback -> didRequestAnimationFrame ?

> Source/WebCore/inspector/InspectorInstrumentation.cpp:996
> +void InspectorInstrumentation::didRequestAnimationFrameCallbackImpl(InstrumentingAgents* instrumentingAgents, int callbackId)

didRequestAnimationFrameCallbackImpl -> didRequestAnimationFrameImpl
Comment 3 Pavel Feldman 2012-02-22 05:12:49 PST
Committed r108486: <http://trac.webkit.org/changeset/108486>
Comment 4 Csaba Osztrogonác 2012-02-22 05:19:08 PST
It broke (at least) the Qt build:
../../../../Source/WebCore/inspector/InspectorController.cpp:72:36: error: base/debug/stack_trace.h: No such file or directory
Comment 5 Csaba Osztrogonác 2012-02-22 09:29:36 PST
fix landed in http://trac.webkit.org/changeset/108488