Bug 79099 - [Qt][WK2] Add frame flattening setting to QWebPreferences
Summary: [Qt][WK2] Add frame flattening setting to QWebPreferences
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-21 06:20 PST by zalan
Modified: 2012-02-22 02:17 PST (History)
2 users (show)

See Also:

Attachments
Patch (7.98 KB, patch)
2012-02-21 06:26 PST, zalan 		no flags Details | Formatted Diff | Diff
Patch (5.05 KB, patch)
2012-02-22 01:38 PST, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2012-02-21 06:20:07 PST 
and enable it by default for qt wk2.
Comment 1 zalan 2012-02-21 06:26:01 PST 
Created attachment 127959 [details]
Patch
Comment 2 Simon Hausmann 2012-02-21 07:16:05 PST 
Comment on attachment 127959 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=127959&action=review

> Source/WebKit2/ChangeLog:3
> +        Add frame flattening setting to QWebPreferences.

You could add a [WK2] prefix before landing :)

> Source/WebKit/qt/declarative/qdeclarativewebview_p.h:316
> +    Q_PROPERTY(bool frameFlatteningEnabled READ frameFlatteningEnabled WRITE setFrameFlatteningEnabled)

Hm, are you sure about adding the property to the QML1 webview? If yes, then the property needs to have a version. (See revision stuff in qdeclarativewebview)
Comment 3 zalan 2012-02-21 07:22:36 PST 
(In reply to comment #2)
> (From update of attachment 127959 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=127959&action=review
> 
> > Source/WebKit2/ChangeLog:3
> > +        Add frame flattening setting to QWebPreferences.
> 
> You could add a [WK2] prefix before landing :)
> 
> > Source/WebKit/qt/declarative/qdeclarativewebview_p.h:316
> > +    Q_PROPERTY(bool frameFlatteningEnabled READ frameFlatteningEnabled WRITE setFrameFlatteningEnabled)
> 
> Hm, are you sure about adding the property to the QML1 webview? If yes, then the property needs to have a version. (See revision stuff in qdeclarativewebview)

I thought having WebKit and WK2 APIs synced up wouldn't be such a bad idea, but I dont have a strong preference on it.
Comment 4 Simon Hausmann 2012-02-22 00:53:08 PST 
(In reply to comment #3)
> (In reply to comment #2)
> > (From update of attachment 127959 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=127959&action=review
> > 
> > > Source/WebKit2/ChangeLog:3
> > > +        Add frame flattening setting to QWebPreferences.
> > 
> > You could add a [WK2] prefix before landing :)
> > 
> > > Source/WebKit/qt/declarative/qdeclarativewebview_p.h:316
> > > +    Q_PROPERTY(bool frameFlatteningEnabled READ frameFlatteningEnabled WRITE setFrameFlatteningEnabled)
> > 
> > Hm, are you sure about adding the property to the QML1 webview? If yes, then the property needs to have a version. (See revision stuff in qdeclarativewebview)
> 
> I thought having WebKit and WK2 APIs synced up wouldn't be such a bad idea, but I dont have a strong preference on it.

I suggest we keep the QML1 API untouched, as we're not actively using it.
Comment 5 zalan 2012-02-22 00:54:55 PST 
Comment on attachment 127959 [details]
Patch

new patch is coming up.
Comment 6 zalan 2012-02-22 01:38:06 PST 
Created attachment 128157 [details]
Patch
Comment 7 Simon Hausmann 2012-02-22 01:42:20 PST 
Comment on attachment 128157 [details]
Patch

r=me, but we have to be careful to not use it when WebKit is used on platforms like Windows or Mac OS, where browser show scrollbars.
Comment 8 WebKit Review Bot 2012-02-22 02:17:04 PST 
Comment on attachment 128157 [details]
Patch

Clearing flags on attachment: 128157

Committed r108471: <http://trac.webkit.org/changeset/108471>
Comment 9 WebKit Review Bot 2012-02-22 02:17:18 PST 
All reviewed patches have been landed.  Closing bug.