Bug 79099 – [Qt][WK2] Add frame flattening setting to QWebPreferences

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[zalan]

and enable it by default for qt wk2.

[zalan]

Created attachment 127959 [details]
Patch

[Simon Hausmann]

Comment on attachment 127959 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=127959&action=review

> Source/WebKit2/ChangeLog:3
> +        Add frame flattening setting to QWebPreferences.

You could add a [WK2] prefix before landing :)

> Source/WebKit/qt/declarative/qdeclarativewebview_p.h:316
> +    Q_PROPERTY(bool frameFlatteningEnabled READ frameFlatteningEnabled WRITE setFrameFlatteningEnabled)

Hm, are you sure about adding the property to the QML1 webview? If yes, then the property needs to have a version. (See revision stuff in qdeclarativewebview)

[zalan]

(In reply to comment #2)
> (From update of attachment 127959 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=127959&action=review
> 
> > Source/WebKit2/ChangeLog:3
> > +        Add frame flattening setting to QWebPreferences.
> 
> You could add a [WK2] prefix before landing :)
> 
> > Source/WebKit/qt/declarative/qdeclarativewebview_p.h:316
> > +    Q_PROPERTY(bool frameFlatteningEnabled READ frameFlatteningEnabled WRITE setFrameFlatteningEnabled)
> 
> Hm, are you sure about adding the property to the QML1 webview? If yes, then the property needs to have a version. (See revision stuff in qdeclarativewebview)

I thought having WebKit and WK2 APIs synced up wouldn't be such a bad idea, but I dont have a strong preference on it.

[Simon Hausmann]

(In reply to comment #3)
> (In reply to comment #2)
> > (From update of attachment 127959 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=127959&action=review
> > 
> > > Source/WebKit2/ChangeLog:3
> > > +        Add frame flattening setting to QWebPreferences.
> > 
> > You could add a [WK2] prefix before landing :)
> > 
> > > Source/WebKit/qt/declarative/qdeclarativewebview_p.h:316
> > > +    Q_PROPERTY(bool frameFlatteningEnabled READ frameFlatteningEnabled WRITE setFrameFlatteningEnabled)
> > 
> > Hm, are you sure about adding the property to the QML1 webview? If yes, then the property needs to have a version. (See revision stuff in qdeclarativewebview)
> 
> I thought having WebKit and WK2 APIs synced up wouldn't be such a bad idea, but I dont have a strong preference on it.

I suggest we keep the QML1 API untouched, as we're not actively using it.

[zalan]

Comment on attachment 127959 [details]
Patch

new patch is coming up.

[zalan]

Created attachment 128157 [details]
Patch

[Simon Hausmann]

Comment on attachment 128157 [details]
Patch

r=me, but we have to be careful to not use it when WebKit is used on platforms like Windows or Mac OS, where browser show scrollbars.

[WebKit Review Bot]

Comment on attachment 128157 [details]
Patch

Clearing flags on attachment: 128157

Committed r108471: <http://trac.webkit.org/changeset/108471>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.