RESOLVED FIXED Bug 79088
[BlackBerry] Upstream Icon class in platform/graphics/blackberry 
https://bugs.webkit.org/show_bug.cgi?id=79088
Summary [BlackBerry] Upstream Icon class in platform/graphics/blackberry
Robin Cao
Reported 2012-02-21 01:16:37 PST
Add the implementation of Icon class in platform/graphics/blackberry.
Attachments
patch (2.50 KB, patch)
2012-02-21 01:30 PST, Robin Cao 		no flags
DetailsFormatted DiffDiff
updated patch -- remove unused parameter (2.49 KB, patch)
2012-02-21 19:21 PST, Robin Cao 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Robin Cao
Comment 1 2012-02-21 01:30:51 PST
Created attachment 127936 [details] patch
Antonio Gomes
Comment 2 2012-02-21 19:06:54 PST
Comment on attachment 127936 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=127936&action=review > Source/WebCore/platform/graphics/blackberry/IconBlackBerry.cpp:39 > +PassRefPtr<Icon> Icon::createIconForFiles(const Vector<String>& filenames) param_unused here
Robin Cao
Comment 3 2012-02-21 19:21:58 PST
Created attachment 128111 [details] updated patch -- remove unused parameter
WebKit Review Bot
Comment 4 2012-02-21 20:34:04 PST
Comment on attachment 128111 [details] updated patch -- remove unused parameter Clearing flags on attachment: 128111 Committed r108440: <http://trac.webkit.org/changeset/108440>
WebKit Review Bot
Comment 5 2012-02-21 20:34:09 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.