Bug 79074 - <style scoped>: Add runtime-flag
Summary: <style scoped>: Add runtime-flag
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Roland Steiner
URL:
Keywords:
Depends on:
Blocks: 49142
  Show dependency treegraph
 
Reported: 2012-02-20 21:25 PST by Roland Steiner
Modified: 2012-02-22 02:45 PST (History)
4 users (show)

See Also:


Attachments
Patch (12.31 KB, patch)
2012-02-20 22:36 PST, Roland Steiner
dglazkov: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Roland Steiner 2012-02-20 21:25:33 PST
Add a runtime flag to enable/disable <style scoped> if compiled with ENABLE(STYLE_SCOPED).
Comment 1 Roland Steiner 2012-02-20 22:36:19 PST
Created attachment 127920 [details]
Patch

patch, webkit-side - adds runtime flag in WebKit (default is off), enables STYLE_SCOPED compile-time flag for Chromium.
Comment 2 Dimitri Glazkov (Google) 2012-02-21 08:52:32 PST
Comment on attachment 127920 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=127920&action=review

> Source/WebCore/css/CSSStyleSelector.cpp:451
> +    // Disregard if <style scoped> is runtime-disabled.

This redundant comment is redundant.

> Source/WebCore/html/HTMLStyleElement.cpp:93
> +    // Do nothing if <style scoped> is runtime-disabled.

Ditto.
Comment 3 Roland Steiner 2012-02-22 02:45:00 PST
Committed r108474: <http://trac.webkit.org/changeset/108474>