Bug 79072 - [chromium] Plumb extensionGroup into didCreateScriptContext().
Summary: [chromium] Plumb extensionGroup into didCreateScriptContext().
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: James Kozianski
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-20 20:29 PST by James Kozianski
Modified: 2012-02-27 19:31 PST (History)
5 users (show)

See Also:


Attachments
Patch (7.34 KB, patch)
2012-02-20 20:30 PST, James Kozianski
no flags Details | Formatted Diff | Diff
Patch for landing (7.40 KB, patch)
2012-02-27 16:01 PST, James Kozianski
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description James Kozianski 2012-02-20 20:29:41 PST
[chromium] Plumb extensionGroup into didCreateScriptContext().
Comment 1 James Kozianski 2012-02-20 20:30:40 PST
Created attachment 127906 [details]
Patch
Comment 2 WebKit Commit Bot 2012-02-23 19:19:33 PST
Please wait for approval from fishd@chromium.org before submitting because this patch contains changes to the Chromium public API.
Comment 3 Darin Fisher (:fishd, Google) 2012-02-23 22:37:42 PST
Comment on attachment 127906 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=127906&action=review

> Source/WebKit/chromium/public/WebFrameClient.h:300
> +    virtual void didCreateScriptContext(WebFrame*, v8::Handle<v8::Context>, int extensionGroup, int worldId) { }

Is your plan to land a Chromium change ahead of this change that implements this new method signature?
Comment 4 James Kozianski 2012-02-26 18:34:54 PST
(In reply to comment #3)
> (From update of attachment 127906 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=127906&action=review
> 
> > Source/WebKit/chromium/public/WebFrameClient.h:300
> > +    virtual void didCreateScriptContext(WebFrame*, v8::Handle<v8::Context>, int extensionGroup, int worldId) { }
> 
> Is your plan to land a Chromium change ahead of this change that implements this new method signature?

Yep, that's right.
Comment 5 James Kozianski 2012-02-27 16:01:31 PST
Created attachment 129120 [details]
Patch for landing
Comment 6 WebKit Review Bot 2012-02-27 19:31:19 PST
Comment on attachment 129120 [details]
Patch for landing

Clearing flags on attachment: 129120

Committed r109064: <http://trac.webkit.org/changeset/109064>
Comment 7 WebKit Review Bot 2012-02-27 19:31:23 PST
All reviewed patches have been landed.  Closing bug.