Bug 79072 – [chromium] Plumb extensionGroup into didCreateScriptContext().

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[James Kozianski]

[chromium] Plumb extensionGroup into didCreateScriptContext().

[James Kozianski]

Created attachment 127906 [details]
Patch

[WebKit Commit Bot]

Please wait for approval from [e-mail] before submitting because this patch contains changes to the Chromium public API.

[Darin Fisher (:fishd, Google)]

Comment on attachment 127906 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=127906&action=review

> Source/WebKit/chromium/public/WebFrameClient.h:300
> +    virtual void didCreateScriptContext(WebFrame*, v8::Handle<v8::Context>, int extensionGroup, int worldId) { }

Is your plan to land a Chromium change ahead of this change that implements this new method signature?

[James Kozianski]

(In reply to comment #3)
> (From update of attachment 127906 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=127906&action=review
> 
> > Source/WebKit/chromium/public/WebFrameClient.h:300
> > +    virtual void didCreateScriptContext(WebFrame*, v8::Handle<v8::Context>, int extensionGroup, int worldId) { }
> 
> Is your plan to land a Chromium change ahead of this change that implements this new method signature?

Yep, that's right.

[James Kozianski]

Created attachment 129120 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 129120 [details]
Patch for landing

Clearing flags on attachment: 129120

Committed r109064: <http://trac.webkit.org/changeset/109064>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.