Bug 79071 - ShadowRootList should have recalculation flag instead of ShadowRoot.
Summary: ShadowRootList should have recalculation flag instead of ShadowRoot.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Shinya Kawanaka
URL:
Keywords:
Depends on:
Blocks: 77931 79079
  Show dependency tree / graph
 
Reported: 2012-02-20 20:12 PST by Shinya Kawanaka
Modified: 2012-02-23 18:36 PST (History)
10 users (show)

See Also:

Attachments
WIP (12.60 KB, patch)
2012-02-20 21:04 PST, Shinya Kawanaka 		no flags Details | Formatted Diff | Diff
Patch (15.57 KB, patch)
2012-02-22 23:44 PST, Shinya Kawanaka 		no flags Details | Formatted Diff | Diff
Patch (15.57 KB, patch)
2012-02-22 23:50 PST, Shinya Kawanaka 		no flags Details | Formatted Diff | Diff
Patch (15.14 KB, patch)
2012-02-23 00:43 PST, Shinya Kawanaka 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Shinya Kawanaka 2012-02-20 20:12:02 PST 
When recalculating ShadowRoot, we want to recalculate all shadow subtrees instead of shadow root.
So ShadowRootList should have those flags instead of ShadowRoot.
Comment 1 Shinya Kawanaka 2012-02-20 21:04:19 PST 
Created attachment 127911 [details]
WIP
Comment 2 Shinya Kawanaka 2012-02-22 23:44:20 PST 
Created attachment 128412 [details]
Patch
Comment 3 Philippe Normand 2012-02-22 23:49:26 PST 
Comment on attachment 128412 [details]
Patch

Attachment 128412 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/11574156
Comment 4 Shinya Kawanaka 2012-02-22 23:50:15 PST 
Created attachment 128413 [details]
Patch
Comment 5 Hajime Morrita 2012-02-23 00:21:35 PST 
Comment on attachment 128413 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=128413&action=review

> Source/WebCore/dom/ShadowRoot.h:77
> +    ShadowRootList* belongingShadowRootList() const;

I think we can just call it parent or parentList. or list?
Honestly I feel this is no longer list.

> Source/WebCore/dom/ShadowRootList.cpp:208
> +    if (hostNode)

Is this possible to null?

> Source/WebCore/dom/ShadowRootList.h:30
> +#include "Node.h"

Why do we need this?
Comment 6 Shinya Kawanaka 2012-02-23 00:43:22 PST 
Created attachment 128424 [details]
Patch
Comment 7 Shinya Kawanaka 2012-02-23 00:44:55 PST 
(In reply to comment #5)
> (From update of attachment 128413 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=128413&action=review
> 
> > Source/WebCore/dom/ShadowRoot.h:77
> > +    ShadowRootList* belongingShadowRootList() const;
> 
> I think we can just call it parent or parentList. or list?
> Honestly I feel this is no longer list.

Yeah, I'm now thinking so.
Let us make another bug to consider a name of ShadowRootList.

BTW, I've chosen list() here.

> 
> > Source/WebCore/dom/ShadowRootList.cpp:208
> > +    if (hostNode)
> 
> Is this possible to null?

No. Done.

> 
> > Source/WebCore/dom/ShadowRootList.h:30
> > +#include "Node.h"
> 
> Why do we need this?

Hmm... We don't need this apparently.
Comment 8 WebKit Review Bot 2012-02-23 02:15:17 PST 
Comment on attachment 128424 [details]
Patch

Rejecting attachment 128424 [details] from commit-queue.

shinyak@chromium.org does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.
Comment 9 Hajime Morrita 2012-02-23 17:37:54 PST 
Comment on attachment 128424 [details]
Patch

haraken told me that cq+ bot is somehow rolled back to the older revision. I hope it'll be fixed soon.
Comment 10 WebKit Review Bot 2012-02-23 18:36:43 PST 
Comment on attachment 128424 [details]
Patch

Clearing flags on attachment: 128424

Committed r108713: <http://trac.webkit.org/changeset/108713>
Comment 11 WebKit Review Bot 2012-02-23 18:36:49 PST 
All reviewed patches have been landed.  Closing bug.