RESOLVED FIXED 79064
Remove [TreatReturnedNullStringAsNull] from HTMLMediaElement.mediaGroup 
https://bugs.webkit.org/show_bug.cgi?id=79064
Summary Remove [TreatReturnedNullStringAsNull] from HTMLMediaElement.mediaGroup
Kentaro Hara
Reported 2012-02-20 18:22:22 PST
[TreatReturnedNullStringAsNull] is a typo of [TreatReturnedNullStringAs=Null]. But as far as I read the spec (http://www.whatwg.org/specs/web-apps/current-work/multipage/the-video-element.html#attr-media-mediagroup), there is no statement about what value should be returned when HTMLMediaElement.mediaGroup is not yet initialized. In particular, there is no statement that says "null should be returned when HTMLMediaElement.mediaGroup is not initialized". Thus, I think that instead of fixing the typo, just removing [TreatReturnedNullStringAsNull] would make sense. Removing [TreatReturnedNullStringAsNull] does not change the current behavior.
Attachments
Patch (2.07 KB, patch)
2012-02-20 18:25 PST, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
Patch (2.11 KB, patch)
2012-02-20 20:30 PST, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Kentaro Hara
Comment 1 2012-02-20 18:25:36 PST
Created attachment 127889 [details] Patch
Adam Barth
Comment 2 2012-02-20 20:08:17 PST
Comment on attachment 127889 [details] Patch Can we add a test that verifies this behavior?
Kentaro Hara
Comment 3 2012-02-20 20:30:33 PST
Created attachment 127905 [details] Patch
Kentaro Hara
Comment 4 2012-02-20 20:31:56 PST
(In reply to comment #2) > (From update of attachment 127889 [details]) > Can we add a test that verifies this behavior? media/media-controller.html already has the test: testExpected("video.mediaGroup", ""); I added "Test: media/media-controller.html (No change in the test result)" to ChangeLog.
Hajime Morrita
Comment 5 2012-02-20 21:37:39 PST
Comment on attachment 127905 [details] Patch I'd like to see green cr-linux.
Hajime Morrita
Comment 6 2012-02-20 21:38:16 PST
Also, please take care of ChangeLog diff crash.
WebKit Review Bot
Comment 7 2012-02-20 22:23:42 PST
Comment on attachment 127905 [details] Patch Clearing flags on attachment: 127905 Committed r108305: <http://trac.webkit.org/changeset/108305>
WebKit Review Bot
Comment 8 2012-02-20 22:23:47 PST
All reviewed patches have been landed. Closing bug.
Ian 'Hixie' Hickson
Comment 9 2012-02-21 12:21:18 PST
The mediaGroup IDL attribute on media elements must reflect the mediagroup content attribute. It's always initialised. There's no concept of it not being initialised.
Kentaro Hara
Comment 10 2012-02-21 13:58:00 PST
(In reply to comment #9) > The mediaGroup IDL attribute on media elements must reflect the mediagroup content attribute. It's always initialised. There's no concept of it not being initialised. Hixie: Thanks for the clarification!
Note You need to log in before you can comment on or make changes to this bug.