Bug 79051 - INPUT_SPEECH should be implemented as a PageSupplement.
Summary: INPUT_SPEECH should be implemented as a PageSupplement.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Hajime Morrita
URL:
Keywords:
Depends on:
Blocks: 78440
  Show dependency treegraph
 
Reported: 2012-02-20 16:20 PST by Hajime Morrita
Modified: 2012-02-21 21:46 PST (History)
3 users (show)

See Also:


Attachments
Patch (10.22 KB, patch)
2012-02-21 20:35 PST, Hajime Morrita
no flags Details | Formatted Diff | Diff
Patch for landing (10.21 KB, patch)
2012-02-21 20:57 PST, Hajime Morrita
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Hajime Morrita 2012-02-20 16:20:56 PST
This is series of supplement-ification (Bug 78440).
SpeechIput and its client should be pushed out from Page class using PageSupplement.
Comment 1 Hajime Morrita 2012-02-21 20:35:04 PST
Created attachment 128124 [details]
Patch
Comment 2 Hajime Morrita 2012-02-21 20:36:35 PST
Hi Adam, could you take a look? I feel this is as simple as stamp-able.
Comment 3 Adam Barth 2012-02-21 20:50:01 PST
Comment on attachment 128124 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=128124&action=review

> Source/WebCore/page/SpeechInput.cpp:122
> +    DEFINE_STATIC_LOCAL(AtomicString, name, ("speechInput"));

speechInput => SpeechInput ?
Comment 4 Hajime Morrita 2012-02-21 20:57:39 PST
Created attachment 128125 [details]
Patch for landing
Comment 5 Hajime Morrita 2012-02-21 20:58:22 PST
(In reply to comment #3)
> (From update of attachment 128124 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=128124&action=review
> 
> > Source/WebCore/page/SpeechInput.cpp:122
> > +    DEFINE_STATIC_LOCAL(AtomicString, name, ("speechInput"));
> 
> speechInput => SpeechInput ?
Done. I'll fix other existing naming inconsistency later.
Comment 6 WebKit Review Bot 2012-02-21 21:45:54 PST
Comment on attachment 128125 [details]
Patch for landing

Clearing flags on attachment: 128125

Committed r108446: <http://trac.webkit.org/changeset/108446>
Comment 7 WebKit Review Bot 2012-02-21 21:46:01 PST
All reviewed patches have been landed.  Closing bug.