Bug 79051 – INPUT_SPEECH should be implemented as a PageSupplement.

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Hajime Morrita]

This is series of supplement-ification (Bug 78440).
SpeechIput and its client should be pushed out from Page class using PageSupplement.

[Hajime Morrita]

Created attachment 128124 [details]
Patch

[Hajime Morrita]

Hi Adam, could you take a look? I feel this is as simple as stamp-able.

[Adam Barth]

Comment on attachment 128124 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=128124&action=review

> Source/WebCore/page/SpeechInput.cpp:122
> +    DEFINE_STATIC_LOCAL(AtomicString, name, ("speechInput"));

speechInput => SpeechInput ?

[Hajime Morrita]

Created attachment 128125 [details]
Patch for landing

[Hajime Morrita]

(In reply to comment #3)
> (From update of attachment 128124 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=128124&action=review
> 
> > Source/WebCore/page/SpeechInput.cpp:122
> > +    DEFINE_STATIC_LOCAL(AtomicString, name, ("speechInput"));
> 
> speechInput => SpeechInput ?
Done. I'll fix other existing naming inconsistency later.

[WebKit Review Bot]

Comment on attachment 128125 [details]
Patch for landing

Clearing flags on attachment: 128125

Committed r108446: <http://trac.webkit.org/changeset/108446>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.