Bug 79050 - MEDIA_STREAM should be implemented as a PageSupplement.
Summary: MEDIA_STREAM should be implemented as a PageSupplement.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Hajime Morrita
URL:
Keywords:
Depends on:
Blocks: 78440
  Show dependency treegraph
 
Reported: 2012-02-20 16:18 PST by Hajime Morrita
Modified: 2012-02-21 19:56 PST (History)
3 users (show)

See Also:


Attachments
Patch (19.51 KB, patch)
2012-02-20 18:30 PST, Hajime Morrita
no flags Details | Formatted Diff | Diff
Patch (20.24 KB, patch)
2012-02-20 19:35 PST, Hajime Morrita
abarth: review+
morrita: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Hajime Morrita 2012-02-20 16:18:41 PST
UserMediaClient should be extracted as a PageSupplement to eliminate MEDIA_STREAM ifdef in Page.h.
Comment 1 Hajime Morrita 2012-02-20 18:30:13 PST
Created attachment 127891 [details]
Patch
Comment 2 Philippe Normand 2012-02-20 18:51:16 PST
Comment on attachment 127891 [details]
Patch

Attachment 127891 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/11548449
Comment 3 Hajime Morrita 2012-02-20 19:35:45 PST
Created attachment 127899 [details]
Patch
Comment 4 Hajime Morrita 2012-02-20 19:36:03 PST
Hi Adam, could you take a look? This should be easy.
Note that there are some other ifdefs I don't touch in this change.
I expect They would be handled by the IDL supplemental refactoring.
Comment 5 Adam Barth 2012-02-21 15:54:52 PST
Comment on attachment 127899 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=127899&action=review

> Source/WebCore/mediastream/UserMediaController.cpp:34
> +    DEFINE_STATIC_LOCAL(AtomicString, name, ("userMedia"));

I would have called this UserMediaController to match the class name.  (Just to make sure there are no collisions.)
Comment 6 Hajime Morrita 2012-02-21 19:56:57 PST
Committed r108437: <http://trac.webkit.org/changeset/108437>