Bug 79048 – Enable compositing when a CSS filter is animating

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Dean Jackson]

Now that we have hardware accelerated filters, and support for animation (at least on OS X), we should turn on compositing for animated filters.

[Dean Jackson]

<rdar://problem/10420107>

[Dean Jackson]

Created attachment 127858 [details]
Patch

[Dean Jackson]

This patch seems too easy (but it works as verified by CA_PRINT_TREE). Simon, have I missed something?

[Simon Fraser (smfr)]

Comment on attachment 127858 [details]
Patch

Don't you need to test the layer output (layerTreeAsText())?.  You'll also have to be careful that the first animating thing doesn't throw the rest into layers for the test.

[Dean Jackson]

(In reply to comment #4)
> (From update of attachment 127858 [details])
> Don't you need to test the layer output (layerTreeAsText())?. 

Added a new test for that, but I've run into a problem.

> You'll also have to be careful that the first animating thing doesn't throw the rest into layers for the test.

I've added a couple of non-filtered elements.

The problem is that the fix doesn't work in WebKit2. It works fine in WK1, but with WK2 the layer updates don't get painted. I do see the object jump into compositing mode, but only repaint if I do something tricky in the inspector (like highlight the object, then it paints that frame once).

I've attached a simple example that exercises the feature. Hover over the first blue rectangle and it should animate. Doesn't work in WK2.

[Dean Jackson]

Created attachment 127879 [details]
Patch

[Dean Jackson]

Created attachment 127880 [details]
WK2 No Worky Testcase

[Dean Jackson]

Created attachment 130206 [details]
Patch

[WebKit Review Bot]

Attachment 130206 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/css3..." exit_code: 1
Source/WebCore/rendering/RenderLayerCompositor.cpp:1514:  Line contains only semicolon. If this should be an empty statement, use { } instead.  [whitespace/semicolon] [5]
Total errors found: 1 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Dean Jackson]

Style checker failure is because I have the semicolon for the return statement on a blank line, due to the #if. I think that's ok.

[WebKit Review Bot]

Comment on attachment 130206 [details]
Patch

Attachment 130206 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/11836027

New failing tests:
css3/filters/composited-during-animation-layertree.html

[Dean Jackson]

Comment on attachment 130206 [details]
Patch

Patch no worky in the case where an element is already composited. Also, layer tree output is platform-specific (as shown in failing test for chromium)

[Dean Jackson]

Created attachment 130281 [details]
Patch

[Dean Jackson]

The platform that will produce interesting results for the layout tests is mac-future, but those results are not included here.

[WebKit Review Bot]

Comment on attachment 130281 [details]
Patch

Attachment 130281 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/11833185

New failing tests:
css3/filters/composited-during-transition-layertree.html
css3/filters/composited-during-animation-layertree.html

[Dean Jackson]

I'm not sure why the chromium tests are failing. Since the results are platform specific anyway, I'll put them in the platform dir.

[Dean Jackson]

http://trac.webkit.org/changeset/109953