Bug 79045 – Does not build on GNU Hurd

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Gustavo Noronha (kov)]

From the Debian bug:

The problem is due to the missing PTHREAD_KEYS_MAX definition (which is
optional in POSIX, though).
The attached patch does two things:
- Source/JavaScriptCore/wtf/Platform.h
  defines WTF_OS_HURD in hopefully a suitable way for upstream;
  it would be nice if you could send it upstream (so I don't need to
  patch also the various webkit copies for it).
- Source/JavaScriptCore/wtf/ThreadIdentifierDataPthreads.cpp
  adds a band-aid fix fix for the lack of PTHREAD_KEYS_MAX definition,
  with a value which should not cause issues;
  this part should not go upstream but stay locally in Debian for now,
  as it will need either a better fix in webkit or a fix in
  glibc/libpthread for Hurd.

[Gustavo Noronha (kov)]

Created attachment 127852 [details]
Patch

[WebKit Review Bot]

Comment on attachment 127852 [details]
Patch

Rejecting attachment 127852 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1

Gustavo Noronha found in /mnt/git/webkit-commit-queue/Source/JavaScriptCore/ChangeLog does not appear to be a valid reviewer according to committers.py.
ERROR: /mnt/git/webkit-commit-queue/Source/JavaScriptCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://queues.webkit.org/results/11552258

[Gustavo Noronha (kov)]

Created attachment 127864 [details]
Patch

[WebKit Review Bot]

Comment on attachment 127864 [details]
Patch

Clearing flags on attachment: 127864

Committed r108279: <http://trac.webkit.org/changeset/108279>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.