Bug 79030 - Web Inspector: add "show paint rectangles" setting.
Summary: Web Inspector: add "show paint rectangles" setting.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-20 06:39 PST by Pavel Feldman
Modified: 2012-02-21 03:28 PST (History)
10 users (show)

See Also:


Attachments
Patch (46.30 KB, patch)
2012-02-20 06:48 PST, Pavel Feldman
no flags Details | Formatted Diff | Diff
Patch (22.47 KB, patch)
2012-02-21 01:51 PST, Pavel Feldman
yurys: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2012-02-20 06:39:08 PST
It is often useful to see what rectangles are being repainted. Adding a setting that allows toggling it.
Comment 1 Pavel Feldman 2012-02-20 06:48:37 PST
Created attachment 127817 [details]
Patch
Comment 2 Timothy Hatcher 2012-02-20 10:49:18 PST
Why does the client need to do this? Same reason the client does node highlights?
Comment 3 Pavel Feldman 2012-02-20 11:02:41 PST
(In reply to comment #2)
> Why does the client need to do this? Same reason the client does node highlights?

I was going to expose the feature that was already there in Chrome first. I will try upstreaming it in case it sticks. Here is what it looks like in Chrome today: http://www.youtube.com/watch?v=Ea41RdQ1oFQ&t=1m30s
Comment 4 Timothy Hatcher 2012-02-20 11:28:19 PST
Hovering in the Timeline seems more interesting. That is a different API right?
Comment 5 Pavel Feldman 2012-02-20 21:35:17 PST
Hovering in the Timeline is using data collected while instrumenting to highlight regions on the screen, so it is different. To your client concern, I'll rework this change to upstream Chrome's debug paint rects all in one change - should not be much work.
Comment 6 Pavel Feldman 2012-02-21 01:51:20 PST
Created attachment 127939 [details]
Patch
Comment 7 Pavel Feldman 2012-02-21 03:28:34 PST
Committed r108330: <http://trac.webkit.org/changeset/108330>