Bug 79024 - Web Inspector: clicking empty space should not re-enter edit mode
Summary: Web Inspector: clicking empty space should not re-enter edit mode
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-20 03:31 PST by Pavel Feldman
Modified: 2012-02-21 03:32 PST (History)
10 users (show)

See Also:


Attachments
Patch (2.35 KB, patch)
2012-02-20 03:33 PST, Pavel Feldman
no flags Details | Formatted Diff | Diff
Patch (3.49 KB, patch)
2012-02-20 03:55 PST, Pavel Feldman
no flags Details | Formatted Diff | Diff
Patch (3.42 KB, patch)
2012-02-20 04:15 PST, Pavel Feldman
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2012-02-20 03:31:29 PST
1. Click in the emtpy element.style { } rule's whitespace
2. Editing begins
3. Click on the white space again

Expected: editing ends
Actual: edit mode is re-entered
Comment 1 Pavel Feldman 2012-02-20 03:33:32 PST
Created attachment 127799 [details]
Patch
Comment 2 Pavel Feldman 2012-02-20 03:55:18 PST
Created attachment 127803 [details]
Patch
Comment 3 Alexander Pavlov (apavlov) 2012-02-20 04:08:46 PST
Comment on attachment 127803 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=127803&action=review

> Source/WebCore/ChangeLog:1
>  2012-02-20  pfeldman@chomium.org  <pavel.feldman@gmail.com>

Bad user data (and a mistype in the chromium.org email)
Comment 4 Pavel Feldman 2012-02-20 04:10:50 PST
Comment on attachment 127803 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=127803&action=review

>> Source/WebCore/ChangeLog:1
>>  2012-02-20  pfeldman@chomium.org  <pavel.feldman@gmail.com>
> 
> Bad user data (and a mistype in the chromium.org email)

Blame webkit-patch...
Comment 5 Pavel Feldman 2012-02-20 04:15:10 PST
Created attachment 127804 [details]
Patch
Comment 6 Pavel Feldman 2012-02-21 03:32:26 PST
Comment on attachment 127804 [details]
Patch

Clearing flags on attachment: 127804

Committed r108332: <http://trac.webkit.org/changeset/108332>
Comment 7 Pavel Feldman 2012-02-21 03:32:34 PST
All reviewed patches have been landed.  Closing bug.