Bug 79020 - [BlackBerry] Checkerboard never goes away in tiled accelerated compositing layer
Summary: [BlackBerry] Checkerboard never goes away in tiled accelerated compositing layer
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jakob Petsovits
Depends on:
Reported: 2012-02-20 02:08 PST by Arvid Nilsson
Modified: 2012-03-02 17:22 PST (History)
4 users (show)

See Also:

Patch (9.49 KB, patch)
2012-03-02 11:07 PST, Jakob Petsovits
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Arvid Nilsson 2012-02-20 02:08:48 PST
Upstream webkit/c2249235855dfcc371b1088bb8257c80a74f6684 to bring our file in sync with upstream, which is missing this patch.
Comment 1 Jakob Petsovits 2012-03-02 11:07:14 PST
Created attachment 129924 [details]
Comment 2 Jakob Petsovits 2012-03-02 11:12:42 PST
The above is the patch that Arvid was talking about. It originally included a few hunks in WebPage.cpp too, but those were already upstreamed as part of the original WebPage.cpp upstreaming, so without this patch the WebKit/blackberry code is actually out of sync.

The patch has already been reviewed by Adam Treat internally, so I'm not putting it up for review again as he's an upstream reviewer too. Letting him set the commit-queue flag though.
Comment 3 WebKit Review Bot 2012-03-02 13:05:10 PST
Comment on attachment 129924 [details]

Rejecting attachment 129924 [details] from commit-queue.

New failing tests:
Full output: http://queues.webkit.org/results/11802098
Comment 4 Jakob Petsovits 2012-03-02 13:19:14 PST
Comment on attachment 129924 [details]

What? That's clearly unrelated. Let's hope it was something temporary and whatever tests were broken have been fixed in the meantime. Setting back to cq?.
Comment 5 WebKit Review Bot 2012-03-02 17:22:37 PST
Comment on attachment 129924 [details]

Clearing flags on attachment: 129924

Committed r109638: <http://trac.webkit.org/changeset/109638>
Comment 6 WebKit Review Bot 2012-03-02 17:22:42 PST
All reviewed patches have been landed.  Closing bug.