Bug 79010 - Attached/Detached state must be testable
Summary: Attached/Detached state must be testable
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Shinya Kawanaka
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-19 21:45 PST by Shinya Kawanaka
Modified: 2012-02-20 01:33 PST (History)
6 users (show)

See Also:


Attachments
Test (2.82 KB, patch)
2012-02-19 21:57 PST, Shinya Kawanaka
no flags Details | Formatted Diff | Diff
Test (2.73 KB, patch)
2012-02-19 23:05 PST, Shinya Kawanaka
no flags Details | Formatted Diff | Diff
Patch (5.78 KB, patch)
2012-02-20 00:41 PST, Shinya Kawanaka
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Shinya Kawanaka 2012-02-19 21:45:39 PST
When considering Shadow DOM, light tree won't be rendered but should be attached.
The state 'attached' or 'detached' is currently not testable.
When implementing Shadow DOM, that state will often become wrong by implementation mistakes.
We should have a method to test them in Internals.
Comment 1 Shinya Kawanaka 2012-02-19 21:57:09 PST
Created attachment 127759 [details]
Test
Comment 2 Collabora GTK+ EWS bot 2012-02-19 22:37:10 PST
Comment on attachment 127759 [details]
Test

Attachment 127759 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/11548183
Comment 3 Early Warning System Bot 2012-02-19 22:37:55 PST
Comment on attachment 127759 [details]
Test

Attachment 127759 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/11551077
Comment 4 WebKit Review Bot 2012-02-19 22:48:36 PST
Comment on attachment 127759 [details]
Test

Attachment 127759 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/11550092
Comment 5 Shinya Kawanaka 2012-02-19 23:05:17 PST
Created attachment 127767 [details]
Test
Comment 6 Shinya Kawanaka 2012-02-20 00:41:47 PST
Created attachment 127776 [details]
Patch
Comment 7 WebKit Review Bot 2012-02-20 01:33:31 PST
Comment on attachment 127776 [details]
Patch

Clearing flags on attachment: 127776

Committed r108226: <http://trac.webkit.org/changeset/108226>
Comment 8 WebKit Review Bot 2012-02-20 01:33:35 PST
All reviewed patches have been landed.  Closing bug.