Bug 79009 – Remove a ReadWriteLock class because it seems not to be used anywhere.

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Kwonjin Jeong]

Despite searching all of the WebKit code, I can't find any place using a ReadWriteLock class. It seems to be useless. So, I report a patch that remove the class.

[Kwonjin Jeong]

Created attachment 127758 [details]
patch v.1

[Kwonjin Jeong]

Created attachment 127760 [details]
patch v.2

[Kwonjin Jeong]

Would you give me some review about this patch?

I wonder that this class is really useless or it is used by somewhere which I don't know.

[Gyuyoung Kim]

If you still want to remove  this macro, you need to refer to below url,
https://trac.webkit.org/wiki/DeprecatingFeatures

[Eric Seidel (no email)]

Comment on attachment 127760 [details]
patch v.2

I suspect it might be used internally by Apple (they have non-webkit clients of WTF).  But it's worth a try.

[Mark Rowe (bdash)]

Nope.

[Eric Seidel (no email)]

Comment on attachment 127760 [details]
patch v.2

Then here we go!

[WebKit Review Bot]

Comment on attachment 127760 [details]
patch v.2

Rejecting attachment 127760 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
 2 (offset 17 lines).
patching file Source/WTF/wtf/ThreadingPthreads.cpp
Hunk #1 succeeded at 343 (offset 20 lines).
patching file Source/WebKit/blackberry/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Source/WebKit/blackberry/WebCoreSupport/AboutDataHaveFeatures.in
Hunk #1 succeeded at 30 with fuzz 2 (offset 8 lines).

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Eric Seidel']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue

Full output: http://queues.webkit.org/results/13860459

[Anders Carlsson]

This has been removed.