Bug 79005 - [CMAKE] Check gstreamer minimum required version
Summary: [CMAKE] Check gstreamer minimum required version
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gyuyoung Kim
URL:
Keywords:
Depends on:
Blocks: 79006
  Show dependency treegraph
 
Reported: 2012-02-19 19:19 PST by Gyuyoung Kim
Modified: 2012-02-19 23:42 PST (History)
3 users (show)

See Also:


Attachments
Patch (5.31 KB, patch)
2012-02-19 20:26 PST, Gyuyoung Kim
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gyuyoung Kim 2012-02-19 19:19:37 PST
To enable video requires over 0.10.30 version of GStreamer. This patch checks whether GStreamer version is over 0.10.30.
Comment 1 Gyuyoung Kim 2012-02-19 20:26:38 PST
Created attachment 127751 [details]
Patch
Comment 2 Gyuyoung Kim 2012-02-19 20:37:54 PST
CC'ing Daniel and Patrick
Comment 3 Daniel Bates 2012-02-19 22:40:43 PST
Comment on attachment 127751 [details]
Patch

OK
Comment 4 Daniel Bates 2012-02-19 22:46:10 PST
Comment on attachment 127751 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=127751&action=review

> Source/cmake/FindGStreamer-App.cmake:15
> +libfind_pkg_check_modules(GStreamer-App_PKGCONF gstreamer-app-0.10>=0.10.30)

I'm assuming this syntax actually works.
Comment 5 Gyuyoung Kim 2012-02-19 23:07:50 PST
(In reply to comment #4)
> (From update of attachment 127751 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=127751&action=review
> 
> > Source/cmake/FindGStreamer-App.cmake:15
> > +libfind_pkg_check_modules(GStreamer-App_PKGCONF gstreamer-app-0.10>=0.10.30)
> 
> I'm assuming this syntax actually works.

Yes, this work. I verified on my linux box.
Comment 6 Gyuyoung Kim 2012-02-19 23:09:02 PST
Daniel, could you review Bug 79006 as well ?
Comment 7 WebKit Review Bot 2012-02-19 23:42:14 PST
Comment on attachment 127751 [details]
Patch

Clearing flags on attachment: 127751

Committed r108211: <http://trac.webkit.org/changeset/108211>
Comment 8 WebKit Review Bot 2012-02-19 23:42:20 PST
All reviewed patches have been landed.  Closing bug.