Bug 78996 - Fails to build on platforms where UChar is wchar_t
Summary: Fails to build on platforms where UChar is wchar_t
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-19 09:54 PST by Kalev Lember
Modified: 2012-02-19 11:16 PST (History)
1 user (show)

See Also:


Attachments
Patch (2.50 KB, patch)
2012-02-19 09:56 PST, Kalev Lember
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kalev Lember 2012-02-19 09:54:22 PST
The ICU backend defines UChar as wchar_t on win32.

Source/WebCore/platform/gtk/GtkPopupMenu.cpp: In member function 'bool WebCore::GtkPopupMenu::typeAheadFind(GdkEventKey*)':
Source/WebCore/platform/gtk/GtkPopupMenu.cpp:181:77: error: invalid static_cast from type 'short unsigned int*' to type 'UChar* {aka wchar_t*}'
Source/WebCore/platform/gtk/GtkPopupMenu.cpp:183:82: error: invalid static_cast from type 'short unsigned int*' to type 'UChar* {aka wchar_t*}'
make[1]: *** [Source/WebCore/platform/gtk/libWebCoreGtk_la-GtkPopupMenu.lo] Error 1
Comment 1 Kalev Lember 2012-02-19 09:56:45 PST
Created attachment 127734 [details]
Patch
Comment 2 WebKit Review Bot 2012-02-19 11:16:46 PST
Comment on attachment 127734 [details]
Patch

Clearing flags on attachment: 127734

Committed r108191: <http://trac.webkit.org/changeset/108191>
Comment 3 WebKit Review Bot 2012-02-19 11:16:54 PST
All reviewed patches have been landed.  Closing bug.