Bug 78969 - [GTK] [AC] Generalize WindowContextGL
Summary: [GTK] [AC] Generalize WindowContextGL
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Martin Robinson
URL:
Keywords:
Depends on:
Blocks: 78968
  Show dependency treegraph
 
Reported: 2012-02-18 12:16 PST by Martin Robinson
Modified: 2012-03-02 13:08 PST (History)
4 users (show)

See Also:


Attachments
Patch (24.94 KB, patch)
2012-02-18 12:28 PST, Martin Robinson
no flags Details | Formatted Diff | Diff
Patch also removing unused WindowContextGL (29.63 KB, patch)
2012-02-18 12:32 PST, Martin Robinson
gns: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Robinson 2012-02-18 12:16:35 PST
WindowContextGL should become a general GL context abstraction so that it can be used by both WebGL and accelerated compositing.
Comment 1 Martin Robinson 2012-02-18 12:28:52 PST
Created attachment 127708 [details]
Patch
Comment 2 Martin Robinson 2012-02-18 12:32:31 PST
Created attachment 127709 [details]
Patch also removing unused WindowContextGL
Comment 3 Gustavo Noronha (kov) 2012-03-02 11:45:50 PST
Comment on attachment 127709 [details]
Patch also removing unused WindowContextGL

LGTM
Comment 4 WebKit Review Bot 2012-03-02 12:13:22 PST
Comment on attachment 127709 [details]
Patch also removing unused WindowContextGL

Rejecting attachment 127709 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
/graphics/gtk/WindowGLContext.h'
patching file Source/WebCore/platform/graphics/gtk/WindowGLContextGLX.cpp
rm 'Source/WebCore/platform/graphics/gtk/WindowGLContextGLX.cpp'
patching file Source/WebKit/gtk/WebCoreSupport/AcceleratedCompositingContext.h
patching file Source/WebKit/gtk/WebCoreSupport/AcceleratedCompositingContextGL.cpp

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Gustavo No..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue/

Full output: http://queues.webkit.org/results/11802076
Comment 5 Martin Robinson 2012-03-02 13:08:17 PST
Committed r109605: <http://trac.webkit.org/changeset/109605>