Bug 78963 - [Qt][WK2] Accelerated animations don't work on Mac
Summary: [Qt][WK2] Accelerated animations don't work on Mac
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Noam Rosenthal
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-18 05:17 PST by Noam Rosenthal
Modified: 2012-02-21 14:57 PST (History)
2 users (show)

See Also:


Attachments
Patch (4.44 KB, patch)
2012-02-20 12:51 PST, Noam Rosenthal
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Noam Rosenthal 2012-02-18 05:17:03 PST
[Qt][WK2] Accelerated animations don't work on Mac
Comment 1 Noam Rosenthal 2012-02-20 12:51:11 PST
Created attachment 127842 [details]
Patch
Comment 2 Kenneth Rohde Christiansen 2012-02-21 12:51:54 PST
Comment on attachment 127842 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=127842&action=review

> Source/WebKit2/UIProcess/qt/LayerTreeHostProxyQt.cpp:205
> +    TextureMapperLayer* layer = toTextureMapperLayer(rootLayer());
> +    ASSERT(layer);

Shouldn't that assert not be in toTextureMapperLayer ?
Comment 3 Noam Rosenthal 2012-02-21 13:32:43 PST
(In reply to comment #2)
> (From update of attachment 127842 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=127842&action=review
> 
> > Source/WebKit2/UIProcess/qt/LayerTreeHostProxyQt.cpp:205
> > +    TextureMapperLayer* layer = toTextureMapperLayer(rootLayer());
> > +    ASSERT(layer);
> 
> Shouldn't that assert not be in toTextureMapperLayer ?

No, sometimes it's ok to have NULL.
Comment 4 WebKit Review Bot 2012-02-21 14:57:42 PST
Comment on attachment 127842 [details]
Patch

Clearing flags on attachment: 127842

Committed r108405: <http://trac.webkit.org/changeset/108405>
Comment 5 WebKit Review Bot 2012-02-21 14:57:48 PST
All reviewed patches have been landed.  Closing bug.