RESOLVED FIXED 78956
DFGPropagator.cpp has too many things 
https://bugs.webkit.org/show_bug.cgi?id=78956
Summary DFGPropagator.cpp has too many things
Filip Pizlo
Reported 2012-02-18 00:17:58 PST
It's a bunch of completely separate phases with no relationship to each other. The DFG should have some common and somewhat sensible framework for having phases instead.
Attachments
the patch (174.87 KB, patch)
2012-02-18 00:35 PST, Filip Pizlo 		gyuyoung.kim: commit-queue-
DetailsFormatted DiffDiff
the patch (174.87 KB, patch)
2012-02-18 00:48 PST, Filip Pizlo 		oliver: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2012-02-18 00:35:58 PST
Created attachment 127698 [details] the patch
Gyuyoung Kim
Comment 2 2012-02-18 00:45:28 PST
Comment on attachment 127698 [details] the patch Attachment 127698 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/11539737
Filip Pizlo
Comment 3 2012-02-18 00:48:53 PST
Created attachment 127699 [details] the patch Fixed typo in cmakefiles.
Oliver Hunt
Comment 4 2012-02-18 10:47:15 PST
Comment on attachment 127699 [details] the patch Refactor all the things!!!! r=me
Filip Pizlo
Comment 5 2012-02-18 12:08:24 PST
Landed in http://trac.webkit.org/changeset/108166
Note You need to log in before you can comment on or make changes to this bug.