RESOLVED FIXED 78951
Move stub implementations of ScrollingCoordinator functions into ScrollingCoordinatorNone.cpp 
https://bugs.webkit.org/show_bug.cgi?id=78951
Summary Move stub implementations of ScrollingCoordinator functions into ScrollingCoo...
James Robinson
Reported 2012-02-17 17:52:38 PST
Move stub implementations of ScrollingCoordinator functions into ScrollingCoordinatorNone.cpp
Attachments
Patch (9.76 KB, patch)
2012-02-17 17:54 PST, James Robinson 		no flags
DetailsFormatted DiffDiff
Patch (19.90 KB, patch)
2012-02-17 22:23 PST, James Robinson 		abarth: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
James Robinson
Comment 1 2012-02-17 17:54:25 PST
Created attachment 127681 [details] Patch
James Robinson
Comment 2 2012-02-17 22:23:23 PST
Created attachment 127694 [details] Patch
James Robinson
Comment 3 2012-02-17 23:39:27 PST
I think this will be slightly easier to deal with going forward. I've moved the ::create() calls calls as well so implementations can allocate a subclass with extra data members specific to a given implementation without having to edit the cross-platform header.
Adam Barth
Comment 4 2012-02-18 00:30:44 PST
Comment on attachment 127694 [details] Patch It looks like you might have some spurious changes to the xcodeproj file.
James Robinson
Comment 5 2012-02-19 15:20:40 PST
(In reply to comment #4) > (From update of attachment 127694 [details]) > It looks like you might have some spurious changes to the xcodeproj file. That's what sort-Xcode-project-file did. I can land that part separately.
James Robinson
Comment 6 2012-02-21 10:39:11 PST
http://trac.webkit.org/changeset/108202
Note You need to log in before you can comment on or make changes to this bug.