Bug 78951 - Move stub implementations of ScrollingCoordinator functions into ScrollingCoordinatorNone.cpp
Summary: Move stub implementations of ScrollingCoordinator functions into ScrollingCoo...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: James Robinson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-17 17:52 PST by James Robinson
Modified: 2012-02-21 10:39 PST (History)
3 users (show)

See Also:


Attachments
Patch (9.76 KB, patch)
2012-02-17 17:54 PST, James Robinson
no flags Details | Formatted Diff | Diff
Patch (19.90 KB, patch)
2012-02-17 22:23 PST, James Robinson
abarth: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description James Robinson 2012-02-17 17:52:38 PST
Move stub implementations of ScrollingCoordinator functions into ScrollingCoordinatorNone.cpp
Comment 1 James Robinson 2012-02-17 17:54:25 PST
Created attachment 127681 [details]
Patch
Comment 2 James Robinson 2012-02-17 22:23:23 PST
Created attachment 127694 [details]
Patch
Comment 3 James Robinson 2012-02-17 23:39:27 PST
I think this will be slightly easier to deal with going forward.  I've moved the ::create() calls calls as well so implementations can allocate a subclass with extra data members specific to a given implementation without having to edit the cross-platform header.
Comment 4 Adam Barth 2012-02-18 00:30:44 PST
Comment on attachment 127694 [details]
Patch

It looks like you might have some spurious changes to the xcodeproj file.
Comment 5 James Robinson 2012-02-19 15:20:40 PST
(In reply to comment #4)
> (From update of attachment 127694 [details])
> It looks like you might have some spurious changes to the xcodeproj file.

That's what sort-Xcode-project-file did.  I can land that part separately.
Comment 6 James Robinson 2012-02-21 10:39:11 PST
http://trac.webkit.org/changeset/108202