Bug 78945 - Separate the implementation of registerProtocolHandler from Navigator.cpp
Summary: Separate the implementation of registerProtocolHandler from Navigator.cpp
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-17 16:34 PST by Adam Barth
Modified: 2012-02-21 23:27 PST (History)
1 user (show)

See Also:


Attachments
Patch (21.79 KB, patch)
2012-02-17 16:37 PST, Adam Barth
no flags Details | Formatted Diff | Diff
Patch (26.17 KB, patch)
2012-02-21 23:00 PST, Adam Barth
eric: review+
abarth: commit-queue+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2012-02-17 16:34:30 PST
Separate the implementation of registerProtocolHandler from Navigator.cpp
Comment 1 Adam Barth 2012-02-17 16:37:24 PST
Created attachment 127675 [details]
Patch
Comment 2 Adam Barth 2012-02-17 16:38:02 PST
I'm not entirely convinced that this is the best way to solve this problem.  Another approach is to have a free function for registerProtocolHandler that Navigator.cpp calls.
Comment 3 Eric Seidel (no email) 2012-02-17 16:40:26 PST
Comment on attachment 127675 [details]
Patch

Seems reasonable.  Looks like you're just moving code, and adding a new Suplemental=Navigator idl file.  Is my understanding correct?
Comment 4 Adam Barth 2012-02-17 16:50:57 PST
Yes, and changing references to m_frame to navigator->frame().
Comment 5 Adam Barth 2012-02-21 23:00:07 PST
Created attachment 128137 [details]
Patch
Comment 6 Eric Seidel (no email) 2012-02-21 23:02:28 PST
Comment on attachment 128137 [details]
Patch

LGTM.
Comment 7 Adam Barth 2012-02-21 23:27:39 PST
Committed r108450: <http://trac.webkit.org/changeset/108450>