Remove the remaining uses of CSSStyleDeclaration in Editor
Created attachment 127663 [details] Patch
Comment on attachment 127663 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=127663&action=review > Source/WebCore/ChangeLog:8 > + No new tests. (OOPS!) Oops, this comment should go away.
Created attachment 128005 [details] Updated for ToT
Comment on attachment 128005 [details] Updated for ToT Attachment 128005 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/11556199
Created attachment 128015 [details] GTK and Windows build fixes
Comment on attachment 127663 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=127663&action=review Looks good to me. Great job, BTW :-). Please make sure you check the EWS before landing. I saw you already fixed some build breakage. > Source/WebCore/ChangeLog:22 > + (Editor): The 2 lines above don't add any information. > Source/WebCore/ChangeLog:35 > + (EditorClient): Ditto. > Source/WebKit/mac/WebView/WebFrame.mm:802 > + // FIXME: We shouldn't have to create a copy here. This comment should be as detailed as the one on line 4356 of WebHTMLView.mm. > Source/WebKit/mac/WebView/WebHTMLView.mm:4658 > + // FIXME: We shouldn't have to make a copy here. Same here. > Source/WebKit/mac/WebView/WebView.mm:5528 > + // FIXME: We shouldn't have to make a copy here. Same here.
Comment on attachment 128015 [details] GTK and Windows build fixes Clearing flags on attachment: 128015 Committed r108462: <http://trac.webkit.org/changeset/108462>
All reviewed patches have been landed. Closing bug.
Committed r108562: <http://trac.webkit.org/changeset/108562>