WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
78934
Add line-align property for character grid alignment to line grids
https://bugs.webkit.org/show_bug.cgi?id=78934
Summary
Add line-align property for character grid alignment to line grids
Dave Hyatt
Reported
2012-02-17 13:58:34 PST
Add line-align property for character grid alignment to line grids.
Attachments
Patch
(17.75 KB, patch)
2012-02-17 14:03 PST
,
Dave Hyatt
mitz: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Dave Hyatt
Comment 1
2012-02-17 14:03:02 PST
Created
attachment 127653
[details]
Patch
mitz
Comment 2
2012-02-17 14:12:28 PST
Comment on
attachment 127653
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=127653&action=review
> Source/WebCore/css/CSSPrimitiveValueMappings.h:3193 > +template<> inline CSSPrimitiveValue::CSSPrimitiveValue(LineAlign gridAlign)
Let’s call this parameter lineAlign ;-)
Dave Hyatt
Comment 3
2012-02-17 15:13:53 PST
Fixed in
r108133
.
Csaba Osztrogonác
Comment 4
2012-02-18 04:52:18 PST
(In reply to
comment #3
)
> Fixed in
r108133
.
And you missed to update layout test results. I did it instead of you -
http://trac.webkit.org/changeset/108158
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug