Bug 78934 - Add line-align property for character grid alignment to line grids
Summary: Add line-align property for character grid alignment to line grids
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dave Hyatt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-17 13:58 PST by Dave Hyatt
Modified: 2012-02-18 04:52 PST (History)
1 user (show)

See Also:


Attachments
Patch (17.75 KB, patch)
2012-02-17 14:03 PST, Dave Hyatt
mitz: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dave Hyatt 2012-02-17 13:58:34 PST
Add line-align property for character grid alignment to line grids.
Comment 1 Dave Hyatt 2012-02-17 14:03:02 PST
Created attachment 127653 [details]
Patch
Comment 2 mitz 2012-02-17 14:12:28 PST
Comment on attachment 127653 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=127653&action=review

> Source/WebCore/css/CSSPrimitiveValueMappings.h:3193
> +template<> inline CSSPrimitiveValue::CSSPrimitiveValue(LineAlign gridAlign)

Let’s call this parameter lineAlign ;-)
Comment 3 Dave Hyatt 2012-02-17 15:13:53 PST
Fixed in r108133.
Comment 4 Csaba Osztrogonác 2012-02-18 04:52:18 PST
(In reply to comment #3)
> Fixed in r108133.

And you missed to update layout test results. I did it instead of you - http://trac.webkit.org/changeset/108158