Bug 78926 - Full Screen Refactor Part 2: Remove unnecessary WebKit2 APIs for Full Screen made
Summary: Full Screen Refactor Part 2: Remove unnecessary WebKit2 APIs for Full Screen ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords:
Depends on: 78925
Blocks: 78927 78928 78930
  Show dependency treegraph
 
Reported: 2012-02-17 13:31 PST by Jer Noble
Modified: 2012-03-08 15:16 PST (History)
4 users (show)

See Also:


Attachments
Patch (48.96 KB, patch)
2012-02-17 13:59 PST, Jer Noble
no flags Details | Formatted Diff | Diff
Patch (56.57 KB, patch)
2012-02-20 14:27 PST, Jer Noble
sullivan: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2012-02-17 13:31:06 PST
Now that (bug #78925) compositing mode is no longer used in full-screen mode, remove the WebKit2 APIs which handle these modes.
Comment 1 Jer Noble 2012-02-17 13:59:33 PST
Created attachment 127651 [details]
Patch
Comment 2 Jer Noble 2012-02-20 14:27:37 PST
Created attachment 127850 [details]
Patch

Removed Source/WebKit2/WebProcess/FullScreen/win/WebFullScreenManagerWin.cpp,h
Comment 3 John Sullivan 2012-02-21 11:25:21 PST
Comment on attachment 127850 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=127850&action=review

> Source/WebKit2/UIProcess/WebFullScreenManagerProxy.h:85
> +    void disposeOfLayerClient() { } // FIXME: Remove

These “// FIXME: Remove” comments don’t provide enough context. Is there a bug number about removing them that you could cite here? Otherwise, they need more context about when they can/should be removed.
Comment 4 Jer Noble 2012-02-21 11:27:57 PST
(In reply to comment #3)
> (From update of attachment 127850 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=127850&action=review
> 
> > Source/WebKit2/UIProcess/WebFullScreenManagerProxy.h:85
> > +    void disposeOfLayerClient() { } // FIXME: Remove
> 
> These “// FIXME: Remove” comments don’t provide enough context. Is there a bug number about removing them that you could cite here? Otherwise, they need more context about when they can/should be removed.

Yes, these will be fully removed by the patch in bug #78928.  I'll add that to the comment.
Comment 5 Jer Noble 2012-03-08 15:16:54 PST
Committed r110214: <http://trac.webkit.org/changeset/110214>