Bug 78923 - Update toLower and toUpper tests for Unicode 6.1 changes
Summary: Update toLower and toUpper tests for Unicode 6.1 changes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Michael Saboff
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2012-02-17 12:58 PST by Michael Saboff
Modified: 2012-02-20 11:01 PST (History)
4 users (show)

See Also:


Attachments
Patch (11.63 KB, patch)
2012-02-17 19:16 PST, Michael Saboff
oliver: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Saboff 2012-02-17 12:58:36 PST
Unicode 6.1 was release 31-Jan-2012.  It includes 5 new lower case / upper case mappings that will impact String.prototype.toLowerCase() & String.prototype.toUpperCase(). In addition, there is one mapping added in Unicode 5.2 that may not appear in tests.

The relevant changes in UnicodeData.txt are:
-- Added in 5.2 --
0265;LATIN SMALL LETTER TURNED H;Ll;0;L;;;;;N;;;A78D;;A78D
A78D;LATIN CAPITAL LETTER TURNED H;Lu;0;L;;;;;N;;;;0265;

-- Added in 6.1 --
0266;LATIN SMALL LETTER H WITH HOOK;Ll;0;L;;;;;N;LATIN SMALL LETTER H HOOK;;A7AA;;A7AA
10C7;GEORGIAN CAPITAL LETTER YN;Lu;0;L;;;;;N;;;;2D27;
10CD;GEORGIAN CAPITAL LETTER AEN;Lu;0;L;;;;;N;;;;2D2D;
2CF2;COPTIC CAPITAL LETTER BOHAIRIC KHEI;Lu;0;L;;;;;N;;;;2CF3;
2CF3;COPTIC SMALL LETTER BOHAIRIC KHEI;Ll;0;L;;;;;N;;;2CF2;;2CF2
2D27;GEORGIAN SMALL LETTER YN;Ll;0;L;;;;;N;;;10C7;;10C7
2D2D;GEORGIAN SMALL LETTER AEN;Ll;0;L;;;;;N;;;10CD;;10CD
A792;LATIN CAPITAL LETTER C WITH BAR;Lu;0;L;;;;;N;;;;A793;
A793;LATIN SMALL LETTER C WITH BAR;Ll;0;L;;;;;N;;;A792;;A792
A7AA;LATIN CAPITAL LETTER H WITH HOOK;Lu;0;L;;;;;N;;;;0266;

 JavaScript tests should be updated to test for these changes.  Given that these mappings are likely implemented in platform dependent OS code and various platforms have different adoption timelines, the tests should accept results compliant for Unicode 5 through Unicode 6.1.  For example, the existing JavaScriptCore test JavaScriptCore/tests/mozilla/ecma/String/15.5.4.11-2.js accepts either Unicode 4 or Unicode 5 results.  Maybe the 4.0 expectations can be replaced with acceptance of 5.2 and 6.1 mappings.
Comment 1 Michael Saboff 2012-02-17 19:16:29 PST
Created attachment 127685 [details]
Patch
Comment 2 Michael Saboff 2012-02-17 19:22:41 PST
<rdar://problem/10717057>
Comment 3 WebKit Review Bot 2012-02-17 22:18:14 PST
Comment on attachment 127685 [details]
Patch

Attachment 127685 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/11536769

New failing tests:
fast/js/string-capitalization.html
Comment 4 Michael Saboff 2012-02-20 10:49:10 PST
Committed r108252: <http://trac.webkit.org/changeset/108252>