Bug 78912 - webkit-patch rebaseline-test fails in git new-workdir
Summary: webkit-patch rebaseline-test fails in git new-workdir
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-17 10:31 PST by Dana Jansens
Modified: 2017-07-18 08:30 PDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dana Jansens 2012-02-17 10:31:04 PST 
I have WebKit checked out in ~/s/WebKit
I have chromium checked out in ~/s/c
I have done git-new-workdir ~/s/WebKit ~/s/c/third_party/WebKit to make a checkout in my chromium tree.

~/s/c/third_party/WebKit/.git/* contains mostly symlinks back to ~/s/WebKit/.git/*

The two repos are not on the same branch, or similar revision at all (~/s/WebKit is at the revision I originally cloned at).

When I run webkit-patch rebaseline-test in ~/s/c/third_party/WebKit, it fails on 'git add ~/s/WebKit/...'

Which seems to imply that it is following symlinks in ~/s/c/third_party/WebKit/.git/ back to ~/s/WebKit and trying to work there.
Comment 1 Adam Barth 2012-02-17 10:57:48 PST 
Any git experts interested in helping figure out what we're doing wrong?
Comment 2 Dirk Pranke 2012-02-17 14:06:27 PST 
This sounds an awful lot like bug 46332. I haven't used git-new-workdir in a long time, so it would take me at least a little bit of effort to test if the fix in that bug works, but it should be straightforward for you to you (Dana) to try it (assuming that patch even applies, of course) :)

I would've landed the patch in bug 46332 back then, but got daunted by the prospect of adding tests to the scm module and having to wait forever for them to run :).
Comment 3 Dana Jansens 2012-02-17 14:12:40 PST 
I will try it out!