Bug 78895 - Web Inspector: check undo-redo boundaries based on current action index, not history size.
Summary: Web Inspector: check undo-redo boundaries based on current action index, not ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-17 05:50 PST by Pavel Feldman
Modified: 2012-02-17 08:14 PST (History)
10 users (show)

See Also:


Attachments
Patch (5.00 KB, patch)
2012-02-17 05:51 PST, Pavel Feldman
vsevik: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2012-02-17 05:50:02 PST
Patch to follow.
Comment 1 Pavel Feldman 2012-02-17 05:51:40 PST
Created attachment 127577 [details]
Patch
Comment 2 Vsevolod Vlasov 2012-02-17 08:01:48 PST
Comment on attachment 127577 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=127577&action=review

> Source/WebCore/inspector/InspectorHistory.cpp:93
> +    if (!action->mergeId().isEmpty() && m_afterLastActionIndex > 0 && m_afterLastActionIndex < m_history.size() && action->mergeId() == m_history[m_afterLastActionIndex - 1]->mergeId())

Please remove second condition
Comment 3 Pavel Feldman 2012-02-17 08:14:17 PST
Committed r108075: <http://trac.webkit.org/changeset/108075>